Invalid template instantiation for iterable

[klimick]

https://psalm.dev/r/6dbd395818 (array|Travesable against iterable)
https://psalm.dev/r/383c7f3677 simplified (only iterable)

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/6dbd395818

<?php

declare(strict_types=1);

/**
 * @return SplFixedArray<int>
 */
function getTraversable(): SplFixedArray
{
    return SplFixedArray::fromArray([1, 2, 3]);
}

/**
 * @return array<array-key, int>
 */
function getArray(): array
{
    return [1, 2, 3];
}

/**
 * @template A
 * @template B
 *
 * @param iterable<mixed, A> $lhs
 * @param iterable<mixed, B> $rhs
 * @return SplFixedArray<A|B>
 */
function mergeIterable(iterable $lhs, iterable $rhs): SplFixedArray
{
    return SplFixedArray::fromArray([...$lhs, ...$rhs]); 
}

/**
 * @template A
 * @template B
 *
 * @param array<array-key, A> $lhs
 * @param array<array-key, B> $rhs
 * @return SplFixedArray<A|B>
 */
function mergeArray(array $lhs, array $rhs): SplFixedArray
{
    return SplFixedArray::fromArray([...$lhs, ...$rhs]); 
}

/**
 * @template A
 * @template B
 *
 * @param Traversable<mixed, A> $lhs
 * @param Traversable<mixed, B> $rhs
 * @return SplFixedArray<A|B>
 */
function mergeTraversable(Traversable $lhs, Traversable $rhs): SplFixedArray
{
    return SplFixedArray::fromArray([...$lhs, ...$rhs]); 
}

// Works!
$_merged_traversable = mergeTraversable(getTraversable(), getTraversable());
/** @psalm-trace $_merged_traversable */;

// Works!
$_merged_array = mergeArray(getArray(), getArray());
/** @psalm-trace $_merged_array */;

// Don't :(
$_merged_iterable = mergeIterable(getTraversable(), getTraversable());
/** @psalm-trace $_merged_iterable */;

Psalm output (using commit 10ea05a):

INFO: Trace - 62:41 - $_merged_traversable: SplFixedArray<int>

INFO: Trace - 66:35 - $_merged_array: SplFixedArray<int>

INFO: Trace - 70:38 - $_merged_iterable: SplFixedArray<mixed>

https://psalm.dev/r/383c7f3677

<?php

declare(strict_types=1);

/**
 * @return SplFixedArray<int>
 */
function getTraversable(): SplFixedArray
{
    return SplFixedArray::fromArray([1, 2, 3]);
}

/**
 * @template A
 * @template B
 *
 * @param iterable<mixed, A> $lhs
 * @param iterable<mixed, B> $rhs
 * @return SplFixedArray<A|B>
 */
function mergeIterable(iterable $lhs, iterable $rhs): SplFixedArray
{
    return SplFixedArray::fromArray([...$lhs, ...$rhs]); 
}

// Expected SplFixedArray<int>, actual SplFixedArray<mixed>
$_merged_iterable = mergeIterable(getTraversable(), getTraversable());
/** @psalm-trace $_merged_iterable */;

Psalm output (using commit 10ea05a):

INFO: Trace - 28:38 - $_merged_iterable: SplFixedArray<mixed>

[AndrolGenhald]

FYI line 23 is also a false negative that will be fixed by #8044, unpacking an iterable with non-array-key keys is a fatal error.

[orklah]

output changed radically, did the situation improve?

[AndrolGenhald]

@orklah nope, just the false negative I mentioned showing up everywhere. Here's a fixed version of the second link: https://psalm.dev/r/0d58749a8f

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/0d58749a8f

<?php

declare(strict_types=1);

/**
 * @return SplFixedArray<int>
 */
function getTraversable(): SplFixedArray
{
    return SplFixedArray::fromArray([1, 2, 3]);
}

/**
 * @template A
 * @template B
 *
 * @param iterable<int, A> $lhs
 * @param iterable<int, B> $rhs
 * @return SplFixedArray<A|B>
 */
function mergeIterable(iterable $lhs, iterable $rhs): SplFixedArray
{
    return SplFixedArray::fromArray([...$lhs, ...$rhs]); 
}

// Expected SplFixedArray<int>, actual SplFixedArray<mixed>
$_merged_iterable = mergeIterable(getTraversable(), getTraversable());
/** @psalm-trace $_merged_iterable */;

Psalm output (using commit 7c4228f):

INFO: Trace - 28:38 - $_merged_iterable: SplFixedArray<mixed>