-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[turborepo] file hashing taking 2 minutes before failing #5773
Comments
Can you run |
Thank you for fixing my title, I forgot about it running |
Interesting, can you run your command with |
npx turbo run build -vvv: 2023-08-31T10:00:53.453+0000 [DEBUG] turborepo_lib::shim: Global turbo version: 1.10.12 2023-08-31T10:00:53.484+0000 [DEBUG] turborepo_lib::shim: supports_skip_infer_and_single_package true Here it is the point where it gets stuck for like 2 minutes Packages in scope: crm, eslint-config-custom, shared, tsconfig, validation-objects, web |
Also turbo daemon -vvv 2023-08-31T11:55:39.794+0000 [DEBUG] turborepo_lib::shim: Global turbo version: 1.10.12 2023-08-31T11:55:39.868+0000 [DEBUG] turborepo_lib::shim: supports_skip_infer_and_single_package true |
Update - it started taking like 4 minutes instead of 2 🫠 |
Looking at the where the hang happens, I'm wondering if this isn't daemon related at all, but instead related to file hashing. A few pieces of info that could help me:
|
git rev-parse --show-cdup returns nothing here is the contents of my turbo.json file
|
Update. I ran the
|
@toto1384 Just an update, we're investigating which code path it is taking through the build. In the mean time, I hypothesize that if you pin your If that doesn't resolve it, I'd try In the next little bit we'll be getting additional debug logging in place in order to identify precisely what the issue is with the latest releases. (For context, I'm making informed guesses by choosing points in the history of files in this crate: https://github.com/vercel/turbo/commits/main/crates/turborepo-scm/src) |
Hey Nathan, thanks for the help. But 1.9.5 is still taking a looooong time |
@toto1384: Interesting, can you get me the timing for these, run from the repository root?
|
If 1.9.5 is slow that would likely mean that something about your actual Linux box is strange and For example, here is somebody reporting that pinning 1.9.5 resolving their performance issue: #5908 We'd still like to understand what that is, if we can, so that we can not be slow in whatever situation. We have two code paths here:
Based on your |
Starting everything from scratch would not be realistic, since the site is live. I'll be waiting for a fix in the meantime. If you have any other ideas, feel free to let me know. Thanks for the help |
Also the timing for them:
|
Okay, that's the kind of performance you should be seeing. 😅 We would expect the section of the code where you're seeing the stall to run in Just to triple-check: those numbers come from the Linux box? So, given:
Something is very strange. We'll get additional debug logging in place and ship a canary for you so we can get more data! |
To triple check: yes, that's my ubuntu vm where I'm running those commands from. |
Also, if it helps you with the troubleshooting, I upgraded the version back from 1.9.5 to 1.10.13 and the 1.10.13 version is significantly faster (2 minutes vs. 5+ minutes) |
@toto1384 Still looking into this, although we're currently unable to reproduce it. Perhaps we can narrow down the problem through. If you build individual workspaces, can you determine if there's one particular workspace that causes the build to hang? e.g. build only |
What version of Turborepo are you using?
1.10.12
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Linux
Describe the Bug
Whenever i run any turbo command, it takes approx 2 minutes for turbo to boot up. The error doesn't happen on my mac machine but it happens on the server and it's annoying having downtime until the app builds. The error appeared after a couple of months of it functioning fine.
Also saw this after everything build: Failed to mark outputs as cached for crm#build: rpc error: code = Unknown desc = timed out waiting for cookie
Expected Behavior
To not load 2 minutes for no reason
To Reproduce
Run turborepo on linux for a couple of months until the performance degrades
Reproduction Repo
No response
TURBO-1397
The text was updated successfully, but these errors were encountered: