Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"HYPHYMPI" failing but "hyphy" working #1806

Open
lrschaff opened this issue Feb 4, 2025 · 2 comments
Open

"HYPHYMPI" failing but "hyphy" working #1806

lrschaff opened this issue Feb 4, 2025 · 2 comments
Assignees
Labels
Milestone

Comments

@lrschaff
Copy link

lrschaff commented Feb 4, 2025

Hello HyPhy team,

When using RELAX on 2.5.68, the "hyphy" (non MPI) version works perfectly fine on my dataset. However when using the MPI version, "HYPHYMPI" it seems to fail at "fitting the general descriptive model."

Running with:

$ srun HYPHYMPI RELAX --alignment ./gene_600.fa --tree ./536mammals_ML_tree.nwk --test Foreground --models All --srv Branch-site --multiple-hit "Double+Triple" --keepident true

And getting the error:

[...]
### Fitting the general descriptive (separate k per branch) model
Grid result 7 = -213986.1435143871 (best = -192163.4429078236)Error:

Master node received an error:Operation '^' is not implemented/defined for a AssociativeList
    While computing: utility.Extend(^(mpi.gJHXkMzL.arguments[2]),mpi.gJHXkMzL.result)

Function call stack
1 :  [namespace = mpi.gJHXkMzL] utility.Extend(^(arguments[2]),result);

    Keyword arguments:
        {
         "keepident":"true",
         "multiple-hit":"Double+Triple"
        }
-------
2 :  [namespace = mpi.aux.EaU_Gajr] Call((queue[from])[utility.getGlobalValue("terms.mpi.callback")],from,Eval(result),(queue[from])[utility.getGlobalValue("terms.mpi.arguments")]);

    Keyword arguments:
        {
         "keepident":"true",
         "multiple-hit":"Double+Triple"
        }
-------
3 :  [namespace = mpi.uWUXdajl] node=aux._handle_receieve(queue);

    Keyword arguments:
        {
         "keepident":"true",
         "multiple-hit":"Double+Triple"
        }
-------
4 :  [namespace = mpi.jfvuBvnJ] mpi.QueueComplete(queue);

    Keyword arguments:
        {
         "keepident":"true",
         "multiple-hit":"Double+Triple"
        }
-------
5 :  [namespace = DhYdAqBM] grid_results=mpi.ComputeOnGridSetValues(&likelihoodFunction,run_options[utility.getGlobalValue("terms.search_grid")],{0:model_objects,1:initial_values,2:run_options[utility.getGlobalValue("terms.run_options.proportional_branch_length_scaler")]},"mpi.ComputeOnGrid.SimpleEvaluatorWithValues","mpi.ComputeOnGrid.ResultHandler");

    Keyword arguments:
        {
         "keepident":"true",
         "multiple-hit":"Double+Triple"
        }
-------
6 :  relax.grid_search.results=estimators.FitLF(relax.filter_names,relax.trees,relax.ge_model_map,relax.final_partitioned_mg_results,relax.model_object_map,{"retain-lf-object":TRUE,terms.run_options.apply_user_constraints:"relax.init.k",terms.run_options.proportional_branch_length_scaler:relax.nm.bl_scalers,terms.run_options.optimization_settings:{"OPTIMIZATION_METHOD":"nedler-mead","MAXIMUM_OPTIMIZATION_ITERATIONS":500,"OPTIMIZATION_PRECISION":relax.nm.precision},terms.search_grid:relax.initial_grid,terms.search_restarts:relax.N.initial_guesses,terms.run_options.optimization_log:relax.optimization_log_file(".GE-1-log.json")});

    Keyword arguments:
        {
         "keepident":"true",
         "multiple-hit":"Double+Triple"
        }
-------
[...]

Any insight on how to fix this error will be greatly appreciated.

Thank you!

Lillie

@spond
Copy link
Member

spond commented Feb 4, 2025

Dear @lrschaff,

Looks like a bug with something not being properly exported to compute nodes by MPI. I'll mark it as such and investigate. Thanks for reporting!

Best,
Sergei

@spond spond self-assigned this Feb 4, 2025
@spond spond added the bug label Feb 4, 2025
@spond spond added this to the 2.5.69 milestone Feb 4, 2025
@lrschaff
Copy link
Author

lrschaff commented Feb 4, 2025

Thank you for looking into it!

Best,

Lillie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants