Custom Instantiator breaks ComponentTracker

[mvysny]

Description of the bug

When a CustomInstantiator overrides getOrCreate(), this breaks the ComponentTracker which now starts reporting creation points as Component 'com.vaadin.starter.skeleton.MyInstantiator' at 'MyInstantiator.java' (getOrCreate LINE 15).

Expected behavior

The ComponentTracker should correctly track component creation even if custom instantiator is used.

Minimal reproducible example

@Route("")
public class MainView extends VerticalLayout {
    public MainView() {
        add(ComponentTracker.findCreate(this).toString());
    }
}
public class MyInstantiator extends DefaultInstantiator {
    public MyInstantiator(VaadinService service) {
        super(service);
    }

    @Override
    public <T> T getOrCreate(Class<T> type) {
        return super.getOrCreate(type);
    }

    public static class Factory implements InstantiatorFactory {
        @Override
        public Instantiator createInstantitor(VaadinService service) {
            return new MyInstantiator(service);
        }
    }
}

(don't forget to register the instantiator via META-INF/services as documented at https://vaadin.com/docs/latest/flow/advanced/custom-instantiators ).

When the instantiator is not enabled, the route correctly prints:

Component 'com.vaadin.starter.skeleton.MainView' at 'MainView.java' (<init> LINE 12)

When the custom instantiator is enabled, the route prints:

Component 'com.vaadin.starter.skeleton.MyInstantiator' at 'MyInstantiator.java' (getOrCreate LINE 15)
Online

This is not helpful especially in connection with the infamous "Can't move a node from one state tree to another. If this is intentional, first remove the node from its current state tree by calling removeFromTree." exception.

Versions

• Vaadin / Flow version: 24.6.6
• Java version: 17
• OS version: Ubuntu