Skip to content

Commit f37d575

Browse files
authored
Merge pull request #1658 from fl4via/UNDERTOW-2429_2.3.x
[UNDERTOW-2429] CVE-2024-7885 Fix ProxyProtocolReadListener leak betw…
2 parents 4ab4d51 + 80c125e commit f37d575

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

core/src/main/java/io/undertow/server/protocol/proxy/ProxyProtocolReadListener.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ class ProxyProtocolReadListener implements ChannelListener<StreamSourceChannel>
5656
private InetAddress destAddress;
5757
private int sourcePort = -1;
5858
private int destPort = -1;
59-
private StringBuilder stringBuilder = new StringBuilder();
6059
private boolean carriageReturnSeen = false;
6160
private boolean parsingUnknown = false;
6261

@@ -223,6 +222,7 @@ private void parseProxyProtocolV2(PooledByteBuffer buffer, AtomicBoolean freeBuf
223222
}
224223

225224
private void parseProxyProtocolV1(PooledByteBuffer buffer, AtomicBoolean freeBuffer) throws IOException {
225+
final StringBuilder stringBuilder = new StringBuilder();
226226
while (buffer.getBuffer().hasRemaining()) {
227227
char c = (char) buffer.getBuffer().get();
228228
if (byteCount < NAME.length) {

0 commit comments

Comments
 (0)