Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: umbraco/Umbraco-CMS
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: release-15.2.1
Choose a base ref
...
head repository: umbraco/Umbraco-CMS
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release-15.2.2
Choose a head ref
  • 3 commits
  • 6 files changed
  • 2 contributors

Commits on Feb 18, 2025

  1. Loosen the RTEValue datacontract to improve migrations (#18349)

    Migaroez committed Feb 18, 2025
    Copy the full SHA
    e0d1267 View commit details
  2. Bump version

    Migaroez committed Feb 18, 2025
    Copy the full SHA
    3a753f4 View commit details

Commits on Feb 19, 2025

  1. Modified AspNetCoreRequestAccessor to handle absensce of an HttpContext.

    AndyButland authored and Migaroez committed Feb 19, 2025
    Copy the full SHA
    c198e19 View commit details
2 changes: 1 addition & 1 deletion src/Umbraco.Infrastructure/Models/RichTextEditorValue.cs
Original file line number Diff line number Diff line change
@@ -10,5 +10,5 @@ public class RichTextEditorValue
public required string Markup { get; set; }

[DataMember(Name = "blocks")]
public required RichTextBlockValue? Blocks { get; set; }
public RichTextBlockValue? Blocks { get; set; }
}
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ public AspNetCoreRequestAccessor(
public string? GetRequestValue(string name) => GetFormValue(name) ?? GetQueryStringValue(name);

/// <inheritdoc />
public string? GetQueryStringValue(string name) => _httpContextAccessor.GetRequiredHttpContext().Request.Query[name];
public string? GetQueryStringValue(string name) => _httpContextAccessor.HttpContext?.Request.Query[name];

/// <inheritdoc />
public Uri? GetRequestUrl() => _httpContextAccessor.HttpContext != null
@@ -86,8 +86,8 @@ internal void EnsureApplicationUrl() =>

private string? GetFormValue(string name)
{
HttpRequest request = _httpContextAccessor.GetRequiredHttpContext().Request;
if (!request.HasFormContentType)
HttpRequest? request = _httpContextAccessor.HttpContext?.Request;
if (request?.HasFormContentType is not true)
{
return null;
}
4 changes: 2 additions & 2 deletions src/Umbraco.Web.UI.Client/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/Umbraco.Web.UI.Client/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@umbraco-cms/backoffice",
"license": "MIT",
"version": "15.2.0-rc",
"version": "15.2.2",
"type": "module",
"exports": {
".": null,
Original file line number Diff line number Diff line change
@@ -94,6 +94,22 @@ public void Can_Parse_JObject()
});
}

[Test]
public void Can_Parse_JObject_With_Missing_Blocks()
{
var input = JsonNode.Parse(""""
{
"markup": "<h2>Vælg et af vores mest populære produkter</h2>"
}
"""");

var result = RichTextPropertyEditorHelper.TryParseRichTextEditorValue(input, JsonSerializer(), Logger(), out RichTextEditorValue? value);
Assert.IsTrue(result);
Assert.IsNotNull(value);
Assert.AreEqual("<h2>Vælg et af vores mest populære produkter</h2>", value.Markup);
Assert.IsNull(value.Blocks);
}

[Test]
public void Can_Parse_Blocks_With_Both_Content_And_Settings()
{
2 changes: 1 addition & 1 deletion version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/main/src/NerdBank.GitVersioning/version.schema.json",
"version": "15.2.1",
"version": "15.2.2",
"assemblyVersion": {
"precision": "build"
},