Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock icon immediately colors from gray to green to gray again #3559

Open
9 tasks done
Sworddragon opened this issue Mar 3, 2025 · 2 comments
Open
9 tasks done

Clock icon immediately colors from gray to green to gray again #3559

Sworddragon opened this issue Mar 3, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@Sworddragon
Copy link

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

When manually updating a filter list (ideally when all other filter lists have a gray clock icon) I'm seeing that sometimes other filter lists change their clock icon from gray to green. But a second later those clock icons change their color from green to gray again.

A specific URL where the issue occurs.

/dashboard.html#3p-filters.html

Steps to Reproduce

  1. Open the filter list dashboard at /dashboard.html#3p-filters.html .
  2. Make sure all filter lists have a gray clock icon (e.g. by manually updating them all and waiting for an hour).
  3. Update some filter lists manually (in my case I updated first "uBlock filters - Ads", then "uBlock filters - Badware risks" and last "uBlock filters - Quick fixes".

Expected behavior

All filter lists affected by an update should change their clock icon from gray to green and keep it that way.

Actual behavior

While on step 3 updating the first 2 filter lists worked normally, once I did it with "uBlock filters - Quick fixes" I saw several other filter lists (I believe one of them was EasyList) change their clock icon from gray to green and a second later from green to gray.

I'm not sure if this always reproduces or if this is a race condition dependent on the 2 previous filter list updates and/or a time factor. As I have to always wait for an hour for another test it is tricky to nail it down more precise.

uBO version

1.62.0

Browser name and version

Firefox 135.0.1

Operating System and version

Windows 10 22H2

@stephenhawk8054
Copy link
Member

It's because uBO is doing auto-updated. It checks outdated diff-path every hour.

@gorhill
Copy link
Member

gorhill commented Mar 3, 2025

I see where the issue is in the code. When an asset is updated, a signal is sent to the dashboard that a specific asset was updated, but with not enough information to see whether it was really updated, while assuming it was. Once all the filter lists are reloaded, the dashboard will completely rebuild the list view, but this time with all the information needed. I need to ensure that when an asset is updated, the signal contains all the information needed for an accurate rendering.

@gwarser gwarser added the bug Something isn't working label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants