Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse input is eaten on manual filter list updates on the moment the entry updates its numbers #3555

Open
9 tasks done
Sworddragon opened this issue Feb 27, 2025 · 3 comments

Comments

@Sworddragon
Copy link

Sworddragon commented Feb 27, 2025

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

In the filter list dashboard when a filter list is manually updated by clicking its clock icon it can cause other filter lists to update their numbers. If such a filter list entry is also being manually updated by clicking its clock symbol at the exact moment those numbers update the mouse input is ignored and no filter list update happens.

A specific URL where the issue occurs.

/dashboard.html#3p-filters.html

Steps to Reproduce

  1. Open uBlock Origin's filter list dashboard at /dashboard.html#3p-filters.html .
  2. Update a filter list entry manually by clicking its clock symbol (in the test I did I choose "uBlock filters - Badware risks").
  3. Around 1 second later update a filter list entry that updates now its numbers on the right to its clock icon (in the test I did choose "uBlock filters - Ads". It is a bit tricky to find the exact moment when to click and it might need a few tries by restarting with step 2).

Expected behavior

The filter list updates.

Actual behavior

The filter list doesn't update.

uBO version

1.62.0

Browser name and version

Firefox 135.0.1

Operating System and version

Windows 10 22H2

@u-RraaLL
Copy link
Contributor

u-RraaLL commented Mar 1, 2025

You'll need to make a screen recording showing what you mean. If a list was recently updated, it can simply reload from cache and the clock icon can simply blink without you noticing the update icon. That's the closest I could reproduce by your description.

@gorhill
Copy link
Member

gorhill commented Mar 1, 2025

when a filter list is manually updated by clicking its clock icon it can cause other filter lists to update their numbers

That's not unexpected, filter lists are loaded in memory in undefined order, so what is considered a duplicate in one list can become a duplicate in another list when they are reloaded in memory.

@Sworddragon
Copy link
Author

Sworddragon commented Mar 1, 2025

You'll need to make a screen recording showing what you mean. If a list was recently updated, it can simply reload from cache and the clock icon can simply blink without you noticing the update icon. That's the closest I could reproduce by your description.

A screen recording is a bit tricky here but I would try it with a more detailed example why I think the mouse input is being dropped here.

With the current filters when I click the clock icon for "uBlock filters - Badware risks" its numbers update to 12.011/12.018. If I update "uBlock filters - Ads" afterwards its numbers will change to 40.551/40.667 and "uBlock filters - Badware risks" stays at 12.011/12.018.

If I repeat this over and over "uBlock filters - Ads" will change its numbers between 40.375/40.667 (after updating "uBlock filters - Badware risks") or 40.551/40.667 (after updating "uBlock filters - Ads").

However, when the mouse input bug occurs here - which happens when I click the clock icon for "uBlock filters - Ads" at the very exact moment its numbers switch from 40.375/40.667 to 40.551/40.667 due to the previous "uBlock filters - Badware risks" update neither will the clock symbol show its loading animation (which could be explained by caching, etc. as you mentioned) nor will the numbers update (and this lets me believe the mouse input got dropped here).

Trying to click at the exact moment is slightly tricky and needs a few tries. Usually I achieve this within 1-2 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants