Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Java client to Search API v3 [$50] #29

Closed
roback opened this issue May 9, 2017 · 6 comments · Fixed by #30
Closed

Update Java client to Search API v3 [$50] #29

roback opened this issue May 9, 2017 · 6 comments · Fixed by #30

Comments

@roback
Copy link
Member

roback commented May 9, 2017

Update the client to use the new Blog Search API v3.

Notable changes from the previous version of the Blog Search API are listed under https://developer.twingly.com/resources/search#changes-from-previous-version.

The ruby client was updated in twingly/twingly-search-api-ruby#65, which can be used as help. Some XML fixtures can also be copied from there if needed.

If possible, try to keep all classes/methods/properties backwards compatible with the previous version of the client by marking methods as deprecated. Similar to what was done in the Ruby client.


Did you help close this issue? Go claim the $50 bounty on Bountysource.

@roback roback added the feature label May 9, 2017
@dentarg dentarg changed the title Update client to Search API v3 Update Java client to Search API v3 May 11, 2017
@dentarg
Copy link
Contributor

dentarg commented May 11, 2017

If you are considering solving this issue, you might be interested in also solving one or more of the following issues (they also have bounties from https://www.bountysource.com/)

@twingly-mob twingly-mob changed the title Update Java client to Search API v3 Update Java client to Search API v3 [$50] May 11, 2017
@dentarg
Copy link
Contributor

dentarg commented May 11, 2017

@xSAVIKx interested in the bounty here? :)

@xSAVIKx
Copy link
Contributor

xSAVIKx commented May 11, 2017

@dentarg Yea, why not? :-)

@xSAVIKx
Copy link
Contributor

xSAVIKx commented May 11, 2017

@dentarg should we support both v.2 and v.3 API?

Update:
Looks like we should not. I'd bump version to 3.0.0 in order to follow the API version.

Also, I'd need some API key to test changes, could you please send me one?

@jage
Copy link
Contributor

jage commented May 11, 2017

Hi,

@dentarg should we support both v.2 and v.3 API?

Update:
Looks like we should not. I'd bump version to 3.0.0 in order to follow the API version.

Correct, no need to keep v.2 support.

Also, I'd need some API key to test changes, could you please send me one?

Oh, we should have documented it, but you can register for a free trial (full API access) at https://app.twingly.com/signup

@xSAVIKx
Copy link
Contributor

xSAVIKx commented May 12, 2017

I've submitted a PR with updates to the v3 API.

I'd also ask to increase the bounty if it is possible, cause I've also closed #28 with my updates in order to support compression.

Regards,
Yuri.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants