Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review behavior: exclusive mapping via install_deps or identity_mapping #299

Closed
Tracked by #256
Nour-Mws opened this issue Apr 7, 2023 · 0 comments · Fixed by #349
Closed
Tracked by #256

Review behavior: exclusive mapping via install_deps or identity_mapping #299

Nour-Mws opened this issue Apr 7, 2023 · 0 comments · Fixed by #349
Labels
P2 major: an upcoming release research-needed

Comments

@Nour-Mws
Copy link
Collaborator

Nour-Mws commented Apr 7, 2023

The current behavior (taking into account the PRs currently under review) is that all dependencies not mapped through:

  • user-defined mapping
  • a local environment

will be matched by exactly one of the following mappings in this order:

  • a local env pip-installed from a packages repository if install_deps is true
  • identity mapping if identity_mapping is true

If none of these two mappings is turned on, these deps will be unresolved.

In other terms, it's not possible for the resolver to go through more than one mapping in the following set: {local pip-installed venv, identity mapping, unresolved}.

If install_deps is true and pip installing packages unresolved via the first two mappings (local env, user-defined) fails, FawltyDeps will error out and will not attempt to resolve uninstalled deps via other means.

Does this behavior make sense in all cases or can we envisage cases where it should be amended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 major: an upcoming release research-needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants