test_cmdline: Remove unnecessary asserts for log messages

It is becoming difficult to make changes to our code because our
command-line tests are getting very picky. In particular we have too
many tests that - in addition to verifying some specific, intended
behavior - also check for specific log messages in their output. When we
refactor and change code internally, we often have to fix these tests as
well, even though the tests themselves are not closely related to the
code we're changing.

Make the situation a little easier by removing the verification of
INFO-level log messages from some of our CLI tests. There are still
several INFO-level log message verification remaining, as we do want
_some_ test coverage of these messages.

Author: jherland

tests/test_cmdline.py

@@ -436,17 +436,10 @@ def test_check__simple_project_with_missing_deps__reports_undeclared(
         "- 'requests' imported at:",
         f"    {str(tmp_path / 'code.py')}:1",
     ]
-    expect_logs = [
-        f"INFO:fawltydeps.extract_imports:Finding Python files under {tmp_path}",
-        f"INFO:fawltydeps.extract_imports:Parsing Python file {tmp_path}/code.py",
-        "INFO:fawltydeps.packages:'pandas' was not resolved."
-        " Assuming it can be imported as 'pandas'.",
-    ]
-    output, errors, returncode = run_fawltydeps(
+    output, _errors, returncode = run_fawltydeps(
         "--check", "--detailed", "-v", f"--code={tmp_path}", f"--deps={tmp_path}"
     )
     assert output.splitlines() == expect
-    assert_unordered_equivalence(errors.splitlines(), expect_logs)
     assert returncode == 3
 
 
@@ -463,19 +456,10 @@ def test_check__simple_project_with_extra_deps__reports_unused(
         "- 'pandas' declared in:",
         f"    {tmp_path / 'requirements.txt'}",
     ]
-    expect_logs = [
-        f"INFO:fawltydeps.extract_imports:Finding Python files under {tmp_path}",
-        f"INFO:fawltydeps.extract_imports:Parsing Python file {tmp_path}/code.py",
-        "INFO:fawltydeps.packages:'requests' was not resolved."
-        " Assuming it can be imported as 'requests'.",
-        "INFO:fawltydeps.packages:'pandas' was not resolved."
-        " Assuming it can be imported as 'pandas'.",
-    ]
-    output, errors, returncode = run_fawltydeps(
+    output, _errors, returncode = run_fawltydeps(
         "--check", "--detailed", "-v", f"--code={tmp_path}", f"--deps={tmp_path}"
     )
     assert output.splitlines() == expect
-    assert_unordered_equivalence(errors.splitlines(), expect_logs)
     assert returncode == 4
 
 
@@ -496,17 +480,10 @@ def test_check__simple_project__can_report_both_undeclared_and_unused(
         "- 'pandas' declared in:",
         f"    {tmp_path / 'requirements.txt'}",
     ]
-    expect_logs = [
-        f"INFO:fawltydeps.extract_imports:Finding Python files under {tmp_path}",
-        f"INFO:fawltydeps.extract_imports:Parsing Python file {tmp_path}/code.py",
-        "INFO:fawltydeps.packages:'pandas' was not resolved."
-        " Assuming it can be imported as 'pandas'.",
-    ]
-    output, errors, returncode = run_fawltydeps(
+    output, _errors, returncode = run_fawltydeps(
         "--check", "--detailed", "-v", f"--code={tmp_path}", f"--deps={tmp_path}"
     )
     assert output.splitlines() == expect
-    assert_unordered_equivalence(errors.splitlines(), expect_logs)
     assert returncode == 3  # undeclared is more important than unused
 
 
@@ -527,13 +504,7 @@ def test_check__simple_project__summary_report_with_verbose_logging(
         "",
         VERBOSE_PROMPT,
     ]
-    expect_logs = [
-        f"INFO:fawltydeps.extract_imports:Finding Python files under {tmp_path}",
-        f"INFO:fawltydeps.extract_imports:Parsing Python file {tmp_path}/code.py",
-        "INFO:fawltydeps.packages:'pandas' was not resolved."
-        " Assuming it can be imported as 'pandas'.",
-    ]
-    output, errors, returncode = run_fawltydeps(
+    output, _errors, returncode = run_fawltydeps(
         "--check",
         "--summary",
         "--verbose",
@@ -542,7 +513,6 @@ def test_check__simple_project__summary_report_with_verbose_logging(
         f"{tmp_path}",
     )
     assert output.splitlines() == expect
-    assert_unordered_equivalence(errors.splitlines(), expect_logs)
     assert returncode == 3  # undeclared is more important than unused
 
 
@@ -636,13 +606,7 @@ def test_check_undeclared__simple_project__reports_only_undeclared(
         "- 'requests' imported at:",
         f"    {str(tmp_path / 'code.py')}:1",
     ]
-    expect_logs = [
-        f"INFO:fawltydeps.extract_imports:Finding Python files under {tmp_path}",
-        f"INFO:fawltydeps.extract_imports:Parsing Python file {tmp_path}/code.py",
-        "INFO:fawltydeps.packages:'pandas' was not resolved."
-        " Assuming it can be imported as 'pandas'.",
-    ]
-    output, errors, returncode = run_fawltydeps(
+    output, _errors, returncode = run_fawltydeps(
         "--check-undeclared",
         "--detailed",
         "-v",
@@ -651,7 +615,6 @@ def test_check_undeclared__simple_project__reports_only_undeclared(
         f"{tmp_path}",
     )
     assert output.splitlines() == expect
-    assert_unordered_equivalence(errors.splitlines(), expect_logs)
     assert returncode == 3
 
 
@@ -668,13 +631,7 @@ def test_check_unused__simple_project__reports_only_unused(
         "- 'pandas' declared in:",
         f"    {tmp_path / 'requirements.txt'}",
     ]
-    expect_logs = [
-        f"INFO:fawltydeps.extract_imports:Finding Python files under {tmp_path}",
-        f"INFO:fawltydeps.extract_imports:Parsing Python file {tmp_path}/code.py",
-        "INFO:fawltydeps.packages:'pandas' was not resolved."
-        " Assuming it can be imported as 'pandas'.",
-    ]
-    output, errors, returncode = run_fawltydeps(
+    output, _errors, returncode = run_fawltydeps(
         "--check-unused",
         "--detailed",
         "-v",
@@ -683,7 +640,6 @@ def test_check_unused__simple_project__reports_only_unused(
         f"{tmp_path}",
     )
     assert output.splitlines() == expect
-    assert_unordered_equivalence(errors.splitlines(), expect_logs)
     assert returncode == 4