Skip to content

Commit 6fd2030

Browse files
v4: Improve accessible name of version dropdown in docs navbar (#36504)
- add `sr-only` "Bootstrap", which will be part of the accessible name - extra `sr-only` text to give some context - that the dropdown is about switching versions - remove the redundant id/aria-labelledby for the dropdown - change the control from `<a>` to `<button>`
1 parent d136302 commit 6fd2030

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

site/layouts/partials/docs-navbar.html

+4-4
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@
3131

3232
<ul class="navbar-nav ml-md-auto">
3333
<li class="nav-item dropdown">
34-
<a class="nav-item nav-link dropdown-toggle mr-md-2" href="#" id="bd-versions" data-toggle="dropdown" aria-expanded="false">
35-
v{{ .Site.Params.docs_version }}
36-
</a>
37-
<div class="dropdown-menu dropdown-menu-md-right" aria-labelledby="bd-versions">
34+
<button class="btn nav-link dropdown-toggle mr-md-2" data-toggle="dropdown" aria-expanded="false">
35+
<span class="sr-only">Bootstrap&nbsp;</span> v{{ .Site.Params.docs_version }} <span class="sr-only">(switch to other versions)</span>
36+
</button>
37+
<div class="dropdown-menu dropdown-menu-md-right">
3838
<a class="dropdown-item active" href="/docs/{{ .Site.Params.docs_version }}/">Latest ({{ .Site.Params.docs_version }}.x)</a>
3939
<div class="dropdown-divider"></div>
4040
<a class="dropdown-item" href="https://getbootstrap.com/docs/5.1/">5.1.x</a>

0 commit comments

Comments
 (0)