Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Improve log performance when forking #145

Open
benjamincburns opened this issue Aug 13, 2018 · 2 comments
Open

Improve log performance when forking #145

benjamincburns opened this issue Aug 13, 2018 · 2 comments

Comments

@benjamincburns
Copy link
Contributor

@tcoulter commented on Thu Mar 09 2017

See the way logs are done here: trufflesuite/ganache-cli-archive#179

i.e., instead of making n requests to the forked chain, make 1.

@benjamincburns
Copy link
Contributor Author

The way logs are fetched for forking is very inefficient. There are likely other performance improvements to be made in the forking fallback requests as well.

@area
Copy link
Contributor

area commented Mar 5, 2020

We needed this at Colony, so I've made a set of changes that do this here, which will hopefully prove helpful for whoever picks this issue up in the future. I'm a little frustrated that I had to make statemanager aware of forked chains, but I couldn't see a clean way of doing it otherwise.

Note that this memoizeFork branch this commit is on (though not the linked commit) has my changes related to #471, so don't just go pulling it in, helpful-person-in-the-future!

I might see if I have time to write tests for this (and, indeed, the other) issue in the future to make these in to PR's that could be merged but I'm not holding my breath - I hope this is useful anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Backlog
Development

No branches or pull requests

3 participants