From e99b83d9e08f5273d6f37a6e267771bf9ee82e21 Mon Sep 17 00:00:00 2001 From: Dain Sundstrom Date: Sun, 20 Jan 2019 15:29:26 -0800 Subject: [PATCH 1/3] Improve error message when connector factory not found --- .../src/main/java/io/prestosql/connector/ConnectorManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/presto-main/src/main/java/io/prestosql/connector/ConnectorManager.java b/presto-main/src/main/java/io/prestosql/connector/ConnectorManager.java index 29e7bdc7c12b..628dbf231bd7 100644 --- a/presto-main/src/main/java/io/prestosql/connector/ConnectorManager.java +++ b/presto-main/src/main/java/io/prestosql/connector/ConnectorManager.java @@ -169,7 +169,7 @@ public synchronized ConnectorId createConnection(String catalogName, String conn { requireNonNull(connectorName, "connectorName is null"); ConnectorFactory connectorFactory = connectorFactories.get(connectorName); - checkArgument(connectorFactory != null, "No factory for connector %s", connectorName); + checkArgument(connectorFactory != null, "No factory for connector [%s]. Available factories: %s", connectorName, connectorFactories.keySet()); return createConnection(catalogName, connectorFactory, properties); } From ea2d4214fbed38e3c84e9820ca6c014674d9d4b5 Mon Sep 17 00:00:00 2001 From: Dain Sundstrom Date: Mon, 21 Jan 2019 13:03:07 -0800 Subject: [PATCH 2/3] Add thrift catalog development config --- presto-main/etc/catalog/thrift.properties | 9 +++++++++ presto-main/etc/config.properties | 1 + 2 files changed, 10 insertions(+) create mode 100644 presto-main/etc/catalog/thrift.properties diff --git a/presto-main/etc/catalog/thrift.properties b/presto-main/etc/catalog/thrift.properties new file mode 100644 index 000000000000..15bc4e93da5b --- /dev/null +++ b/presto-main/etc/catalog/thrift.properties @@ -0,0 +1,9 @@ +# +# WARNING +# ^^^^^^^ +# This configuration file is for development only and should NOT be used be +# used in production. For example configuration, see the Presto documentation. +# + +connector.name=presto-thrift +presto.thrift.client.addresses=127.0.0.1:1234 diff --git a/presto-main/etc/config.properties b/presto-main/etc/config.properties index 96d4d17d2337..c4a43cee1771 100644 --- a/presto-main/etc/config.properties +++ b/presto-main/etc/config.properties @@ -39,6 +39,7 @@ plugin.bundles=\ ../presto-mysql/pom.xml,\ ../presto-sqlserver/pom.xml, \ ../presto-postgresql/pom.xml, \ + ../presto-thrift/pom.xml, \ ../presto-tpcds/pom.xml presto.version=testversion From fd34a3cf458a8722d4cfc6dce97e2356d90670a3 Mon Sep 17 00:00:00 2001 From: Dain Sundstrom Date: Sun, 20 Jan 2019 15:45:25 -0800 Subject: [PATCH 3/3] Add configuration option to control the JMX base name --- pom.xml | 1 + .../ConnectorObjectNameGeneratorModule.java | 117 ++++++++++++++++++ .../plugin/hive/HiveClientModule.java | 11 +- .../plugin/hive/HiveConnectorFactory.java | 5 +- .../hive/metastore/HiveMetastoreModule.java | 10 +- .../metastore/file/FileMetastoreModule.java | 11 +- .../metastore/glue/GlueMetastoreModule.java | 11 +- .../thrift/ThriftMetastoreModule.java | 16 +-- .../plugin/hive/s3/HiveS3Module.java | 12 +- .../InternalResourceGroupManager.java | 6 +- .../scheduler/NodeSchedulerExporter.java | 19 ++- .../memory/ClusterMemoryManager.java | 2 +- .../memory/LocalMemoryManagerExporter.java | 3 +- .../prestosql/server/CoordinatorModule.java | 4 +- .../io/prestosql/server/JmxNamingConfig.java | 33 +++++ .../PrefixObjectNameGeneratorModule.java | 77 ++++++++++++ .../io/prestosql/server/PrestoServer.java | 1 + .../sql/planner/OptimizerStatsRecorder.java | 25 +++- .../sql/planner/RuleStatsRecorder.java | 36 +++--- .../prestosql/server/TestJmxNamingConfig.java | 46 +++++++ .../ConnectorObjectNameGeneratorModule.java | 117 ++++++++++++++++++ .../raptor/legacy/RaptorConnectorFactory.java | 3 +- .../raptor/legacy/backup/BackupModule.java | 3 +- .../raptor/legacy/storage/StorageModule.java | 27 ++-- ...ourceGroupConfigurationManagerFactory.java | 1 + .../db/PrefixObjectNameGeneratorModule.java | 93 ++++++++++++++ .../ConnectorObjectNameGeneratorModule.java | 117 ++++++++++++++++++ .../plugin/thrift/ThriftConnectorFactory.java | 3 +- .../prestosql/plugin/thrift/ThriftModule.java | 12 +- 29 files changed, 693 insertions(+), 129 deletions(-) create mode 100644 presto-hive/src/main/java/io/prestosql/plugin/hive/ConnectorObjectNameGeneratorModule.java create mode 100644 presto-main/src/main/java/io/prestosql/server/JmxNamingConfig.java create mode 100644 presto-main/src/main/java/io/prestosql/server/PrefixObjectNameGeneratorModule.java create mode 100644 presto-main/src/test/java/io/prestosql/server/TestJmxNamingConfig.java create mode 100644 presto-raptor-legacy/src/main/java/io/prestosql/plugin/raptor/legacy/ConnectorObjectNameGeneratorModule.java create mode 100644 presto-resource-group-managers/src/main/java/io/prestosql/plugin/resourcegroups/db/PrefixObjectNameGeneratorModule.java create mode 100644 presto-thrift/src/main/java/io/prestosql/plugin/thrift/ConnectorObjectNameGeneratorModule.java diff --git a/pom.xml b/pom.xml index 0b0c0c9e89ab..199d3e10f54e 100644 --- a/pom.xml +++ b/pom.xml @@ -56,6 +56,7 @@ 6.10 3.8.0 1.2.3 + 1.20