Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardware revisions in SConscript #4637

Open
cepetr opened this issue Feb 14, 2025 · 0 comments
Open

Hardware revisions in SConscript #4637

cepetr opened this issue Feb 14, 2025 · 0 comments
Labels
code Code improvements

Comments

@cepetr
Copy link
Contributor

cepetr commented Feb 14, 2025

We should consider separating the two different hardware revision concepts in the SConscript file.

Currently, we have:

  • hw_revision - This ultimately translates into the HW_REVISION symbol used in the C/ASM source code.
  • HW_REVISION argument – This is used in configure_board()

Since these two serve distinct purposes, we might rename them to make distinction clearer:

  • hw_revision/HW_REVISION to compatible_hw_revision/COMPATIBLE_HW_REVISION
    or
  • HW_REVISION argument to BOARD_REVISION
@cepetr cepetr added the code Code improvements label Feb 14, 2025
@cepetr cepetr mentioned this issue Feb 14, 2025
Merged
@TychoVrahe TychoVrahe moved this to 🎯 To do in Firmware Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code Code improvements
Projects
Firmware
Status: 🎯 To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cepetr