-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: ship production ready build to npm #196
Comments
Hi @jmike Please go ahead and create a PR for that if you want to. One important thing that should probably be mentioned here is that this repo is not meant to be used on production. It is for learning and researching purposes only. The only reason for having this repo on npm is probably to make it possible to re-use its functions by other non-production research projects. |
I agree with @trekhleb i'm not sure its a good idea to signal this project is for production use, it might set a precedent of users then wanting to optimise certain functions, which then defeats the learning aspect of it. |
@jasonwilliams this notification it is already in README here. |
ahh i should have RTFM! |
No problem :D |
Perhaps a forked repository with production-ready code that does have such optimizations would be useful. |
J |
@jmike Have you made any progress in this issues? Recently, I worked on a college project and the lack of a proper package in npm made my work very difficult. |
Edit: Resolved via https://babeljs.io/en/setup#installation. What would be the easiest way to reference this project from another project? Cloning the repo and running require(
"../node_modules/javascript-algorithms-and-data-structures/src/algorithms/graph/bellman-ford/bellmanFord.js")
|
Hey,
I noticed that the current version deployed on npm (i.e. https://www.npmjs.com/package/javascript-algorithms-and-data-structures) is more or less a mirror of the source code here.
javascript-algorithms
is really awesome and someone might want to use it as an external library on production (e.g. a web app or node app). Unfortunately, the use of ES modules, complicates things a bit.May I suggest:
I'd be more that willing to provide a PR using rollup + babel.
The text was updated successfully, but these errors were encountered: