Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/aws-s3 response is undefined in .on("upload-error", (file, error, response) => {...}) #5672

Open
2 tasks done
pmioduszewski opened this issue Mar 2, 2025 · 0 comments
Labels

Comments

@pmioduszewski
Copy link

pmioduszewski commented Mar 2, 2025

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

// package.json
{
    "@uppy/aws-s3": "4.2.3",
    "@uppy/core": "4.4.2",
}
  1. Listen for upload-error event (with @uppy/aws-s3 plugin)
    uppy.on("upload-error", (file, error, response) => {
      console.log("Error response:", response) // <--- Error response: undefined
    });
  1. Try to upload a file that fails
  2. The response is undefined

I've found that the response is not passed in the current implementation here:

this.uppy.emit('upload-error', file, err as Error)

Expected behavior

    uppy.on("upload-error", (file, error, response) => {
      console.log("Error response:", response) // <--- Error response: <response should be passed here>
    });

Actual behavior

undefined is found instead of the actual response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant