Skip to content

Commit e9904fe

Browse files
authored
doc: edit onboarding guide to clarify when mailmap addition is needed
PR-URL: nodejs#55334 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent acd698a commit e9904fe

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

onboarding.md

+6-8
Original file line numberDiff line numberDiff line change
@@ -216,16 +216,14 @@ needs to be pointed out separately during the onboarding.
216216
`git show --format=%B 6669b3857f0f43ee0296eb7ac45086cd907b9e94`
217217
* Collaborators are in alphabetical order by GitHub username.
218218
* Optionally, include your personal pronouns.
219-
* The PR should include an addition to the
220-
[mailmap](.mailmap) file if the email
221-
being added to the collaborator list does not match the email used for
222-
commits. Otherwise tooling will not see the collaborator as being active and
223-
may suggest removing them. See
224-
[gitmailmap](https://git-scm.com/docs/gitmailmap) for information on the
225-
format of the mailmap file.
226-
* Add the `Fixes: <collaborator-nomination-issue-url>` to the commit message
219+
* Commit, including a `Fixes: <collaborator-nomination-issue-url>` trailer
227220
so that when the commit lands, the nomination issue url will be
228221
automatically closed.
222+
* Run `tools/find-inactive-collaborators.mjs`. If that command outputs your name,
223+
amend the commit to include an addition to the [mailmap](.mailmap) file. See
224+
[gitmailmap](https://git-scm.com/docs/gitmailmap) for information on the
225+
format of the mailmap file.
226+
* Push the commit to your own fork.
229227
* Label your pull request with the `doc`, `notable-change`, and `fast-track`
230228
labels. The `fast-track` label should cause the Node.js GitHub bot to post a
231229
comment in the pull request asking collaborators to approve the pull request

0 commit comments

Comments
 (0)