Skip to content

Commit 81517fa

Browse files
authored
build: fix building with system icu 76
ICU 76 decided to reduce overlinking[^1] thus `icu-i18n` will no longer add `icu-uc` when linking to shared libraries. This results in undefined symbols/references when trying to build with system ICU 76. [^1]: unicode-org/icu@199bc82 PR-URL: nodejs#55563 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 84fe809 commit 81517fa

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

configure.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1879,7 +1879,7 @@ def icu_download(path):
18791879
elif with_intl == 'system-icu':
18801880
# ICU from pkg-config.
18811881
o['variables']['v8_enable_i18n_support'] = 1
1882-
pkgicu = pkg_config('icu-i18n')
1882+
pkgicu = pkg_config(['icu-i18n', 'icu-uc'])
18831883
if not pkgicu[0]:
18841884
error('''Could not load pkg-config data for "icu-i18n".
18851885
See above errors or the README.md.''')

0 commit comments

Comments
 (0)