Skip to content

Commit 0cbbab9

Browse files
authored
build: exit on unsupported host OS for Android
The Android configure script throws an unhelpful error message telling the user that `toolchain_path` is not defined when the script is run on an unsupported host OS, exit with a more helpful message instead while listing the supported host OSes. PR-URL: nodejs#52882 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 2079a7a commit 0cbbab9

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

android_configure.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ def patch_android():
1010
os.system('patch -f ./deps/v8/src/trap-handler/trap-handler.h < ./android-patches/trap-handler.h.patch')
1111
print("\033[92mInfo: \033[0m" + "Tried to patch.")
1212

13-
if platform.system() == "Windows":
14-
print("android-configure is not supported on Windows yet.")
13+
if platform.system() != "Linux" and platform.system() != "Darwin":
14+
print("android-configure is currently only supported on Linux and Darwin.")
1515
sys.exit(1)
1616

1717
if len(sys.argv) == 2 and sys.argv[1] == "patch":

0 commit comments

Comments
 (0)