Skip to content

Commit 47fa093

Browse files
authored
docs/development "Key points": Two updates and general improvement (#3205)
1 parent 1b5b187 commit 47fa093

File tree

1 file changed

+14
-11
lines changed

1 file changed

+14
-11
lines changed

docs/development.rst

+14-11
Original file line numberDiff line numberDiff line change
@@ -8,32 +8,35 @@ If you're already experienced with submitting GitHub PRs to open-source Python p
88
points you need to know about this project. (If you're not, you should carefully read all the documentation after this
99
section. This section contains only highlights; it's not a substitute for reading this entire file.)
1010

11-
- Check the `style guide <#style-guide>`_ below. Particularly note that lines should be wrapped at 120 characters, not
12-
the PEP-8 standard of 79. The linter will not catch short lines, but most other formatting details should be caught by
13-
the tests and linting below.
11+
- Check the `style guide <#style-guide>`_ below. Note that ``tox -e fix`` will not catch the following:
12+
13+
- Lines wrapped at less than 120 characters. Lines should be wrapped at 120 characters, not the PEP-8 standard of 79.
14+
- Variable names should be at least two characters long.
15+
1416
- Documentation is in `RST <https://docutils.sourceforge.io/docs/user/rst/quickref.html>`_ format; beware the
1517
differences from GitHub Markdown. The tox ``docs`` and ``fix`` targets will catch only some RST errors; documentation
1618
changes *must* be checked visually (see below).
17-
- All PRs require a changelog entry. This should reference an issue if it closes that issue, otherwise reference the PR.
18-
Create one or more (if there's more than one issue) ``docs/changelog/####.{feature,bugfix,doc,removal,misc}.rst`` per
19-
the `changelog entry <#changelog-entries>`_ section below.
19+
- All PRs that make changes visible to an end user require a changelog entry. This should reference an issue if it
20+
closes that issue, otherwise reference the PR. Create one or more (if there's more than one issue)
21+
``docs/changelog/####.{feature,bugfix,doc,removal,misc}.rst`` per the `changelog entry <#changelog-entries>`_ section
22+
below.
2023
- GitHub Actions will do a full set of `tests and checks <#automated-testing>`_ when the PR is submitted. For local
21-
testing you'll need to install your own "top-level" tox; (using `pipx`_ or similar is fine)
22-
and the following targets.
24+
testing you'll need to install your own "top-level" tox (using `pipx`_ or similar is fine) and use the following
25+
targets (tox environments):
2326

2427
- :samp:`tox -e py [-- {pytest-arg ...}]` to `test code changes <#running-tests>`_. This will skip tests for which
2528
you are missing dependencies, but those tests will still be run by GitHub Actions.
26-
- ``tox -e type`` to typecheck changes. (All new code should have type annotations.)
29+
- ``tox -e type`` to typecheck changes. (All new code should have complete type annotations.)
2730
- ``tox -e docs`` to build documentation changes and update the changelog, followed by viewing (with a browser) the
2831
generated HTML files under :file:`.tox/docs_out/`. The required changelog entry can be viewed at the "Release
2932
History" link at the left.
30-
- ``tox -e fix`` to lint code, documentation and any other changes to the repo.
33+
- ``tox -e fix`` to lint code, documentation and any other changes to the repo. This will also fix the code and
34+
write out the changed files; you can update your commit with `git commit --amend`.
3135

3236

3337
Getting started
3438
---------------
3539

36-
3740
``tox`` is a volunteer maintained open source project and we welcome contributions of all forms. The sections below will
3841
help you get started with development, testing, and documentation. We’re pleased that you are interested in working on
3942
tox. This document is meant to get you setup to work on tox and to act as a guide and reference to the development

0 commit comments

Comments
 (0)