Skip to content

Commit

Permalink
Add some information about properly formatted commit messages
Browse files Browse the repository at this point in the history
It does seem like a lot of github users are not used to good commit
message rules, and may never have used git for a project that actually
cares about good logs and nice summary lines.

Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
torvalds committed Sep 6, 2011
1 parent 454a456 commit b659015
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions README
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,24 @@ the right to pass it on as an open source patch.

See: http://gerrit.googlecode.com/svn/documentation/2.0/user-signedoffby.html

Also, please write good git commit messages. A good commit message
looks like this:

header line: explaining the commit in one line

Body of commit message is a few lines of text, explaining things
in more detail, possibly giving some background about the issue
being fixed, etc etc.

The body of the commit message can be several paragrahps, and

This comment has been minimized.

Copy link
@takeontom

takeontom Jan 27, 2017

Spelling.

please do proper word-wrap and keep columns shorter than about
74 characters or so. That way "git log" will show things
nicely even when it's indented.

Reported-by: whoever-reported-it
Signed-off-by: Your Name <[email protected]>

where that header line really should be meaningful, and really should be
just one line. That header line is what is shown by tools like gitk and
shortlog, and should summarize the change in one readable line of text,
independently of the longer explanation.

10 comments on commit b659015

@levinotik
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@egberts
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@georgesequeira
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@pravsingh
Copy link

@pravsingh pravsingh commented on b659015 Jan 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat 👍

@mekicha
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice

@ibrahimcesar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He should say 'Drop the mic' instead of 'Signed-off-by' hahaha

@SamJongenelen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mhaidarhanif
Copy link

@mhaidarhanif mhaidarhanif commented on b659015 Jan 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenhsun
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CatPlanet
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂👌

Please sign in to comment.