Skip to content

Commit 324185a

Browse files
committed
Fix task suspension in GC for JL_TIMING
The timing system does not currently support nesting task suspensions, so this `JL_TIMING_SUSPEND_TASK` added in JuliaLang#51489 is not permitted since it is called from within the GC suspension. This was causing Tracy to crash upon recording with "zone ended twice"
1 parent dabb93a commit 324185a

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/safepoint.c

-1
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,6 @@ void jl_safepoint_wait_thread_resume(void)
201201
// will observe the change to the safepoint, even though the other thread
202202
// might have already observed our gc_state.
203203
// if (!jl_atomic_load_relaxed(&ct->ptls->suspend_count)) return;
204-
JL_TIMING_SUSPEND_TASK(USER, ct);
205204
int8_t state = jl_atomic_load_relaxed(&ct->ptls->gc_state);
206205
jl_atomic_store_release(&ct->ptls->gc_state, JL_GC_STATE_WAITING);
207206
uv_mutex_lock(&ct->ptls->sleep_lock);

0 commit comments

Comments
 (0)