Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PREFER_APPEND_FILE_SYNC env #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chouchouji
Copy link

@chouchouji chouchouji commented Feb 21, 2025

resolve #115

@toplenboren
Copy link
Owner

toplenboren commented Feb 21, 2025

Thanks for the PR. Can you please add some tests, so that no one would be to break your code :-)

@chouchouji chouchouji force-pushed the feat-env branch 4 times, most recently from f770b31 to cafec52 Compare February 22, 2025 04:09
@chouchouji
Copy link
Author

Thanks for the PR. Can you please add some tests, so that no one would be to break your code :-)

Thanks for your review. I had added test cases.

@JounQin
Copy link
Contributor

JounQin commented Mar 9, 2025

But what if the user run simple-git-hooks multi times?

@chouchouji
Copy link
Author

But what if the user run simple-git-hooks multi times?

This is a rare scenario, and we should specify in the document what consequences it will bring.

@JounQin
Copy link
Contributor

JounQin commented Mar 9, 2025

It is a very common practice to use "prepare": "simple-git-hooks" lifecyle script to ensure hooks are always latest.

Oh, I miss understood, a temporary env variable to init simple-git-hooks seems fine enough, not a persist option.

@chouchouji
Copy link
Author

It is a very common practice to use "prepare": "simple-git-hooks" lifecyle script to ensure hooks are always latest.

Oh, I miss understood, a temporary env variable to init simple-git-hooks seems fine enough, not a persist option.

We can provide a detailed explanation of the purpose of this environment variable to prevent unnecessary problems for users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How about appending the file contents instead of replacing them?
3 participants