Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rollup@4 #174

Closed
tbouffard opened this issue Oct 13, 2023 · 5 comments · Fixed by #178
Closed

Add support for rollup@4 #174

tbouffard opened this issue Oct 13, 2023 · 5 comments · Fixed by #178

Comments

@tbouffard
Copy link
Contributor

tbouffard commented Oct 13, 2023

Hi and thanks for this plugin

[email protected] declares "rollup": "^2 || ^3" in peerDependencies

Running npm install in a projet using rollup@4 generates the following error

 npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/rollup
npm ERR!   dev rollup@"~4.0.2" from the root project
npm ERR!   peerOptional rollup@"^2.68.0||^3.0.0||^4.0.0" from @rollup/[email protected]
npm ERR!   node_modules/@rollup/plugin-commonjs
npm ERR!     dev @rollup/plugin-commonjs@"~25.0.5" from the root project
npm ERR!   5 more (@rollup/plugin-node-resolve, @rollup/plugin-terser, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@"^2 || ^3" from [email protected]
npm ERR! node_modules/rollup-plugin-sizes
npm ERR!   dev rollup-plugin-sizes@"~1.0.5" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/rollup
npm ERR!   peer rollup@"^2 || ^3" from [email protected]
npm ERR!   node_modules/rollup-plugin-sizes
npm ERR!     dev rollup-plugin-sizes@"~1.0.5" from the root project

Possible workaround that could be evaluated (same as in #142): use the --legacy-peer-deps option

@tivac
Copy link
Owner

tivac commented Oct 13, 2023

I'd accept a pr to update that, assuming it actually works with v4

@tbouffard
Copy link
Contributor Author

I have able to use [email protected] with [email protected] by setting legacy-peer-deps=true. See process-analytics/bpmn-visualization-js#2927 (review)

Can other users check that it works on their side to make sure that the plugin works with rollup v4?
Thank you.

@ricovitch
Copy link

Looks to work for me using legacy-peer-deps option to install.

@tivac
Copy link
Owner

tivac commented Nov 23, 2023

Released as [email protected]

@tbouffard
Copy link
Contributor Author

Thanks for merging the PR. I have been able to successfully integrate the new version in my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants