Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update deprecated ongenerate hook to generateBundle #15

Merged
merged 1 commit into from
Dec 7, 2019

Conversation

fuzetsu
Copy link
Contributor

@fuzetsu fuzetsu commented Jun 17, 2019

👋 I was trying out this package when I noticed the deprecation warning for ongenerate.

This seems to fix it AFAIC

bundles could represent multiple output files, but since the modules would be the same I just grab the first file.

Let me know if you think this assumption is incorrect.

I didn't mix it into this PR, but it also be worth running npm audit fix, there were some warnings.

fixes #13

@tivac tivac mentioned this pull request Dec 7, 2019
@tivac tivac changed the title update deprecated ongenerate hook to generateBundle feat: update deprecated ongenerate hook to generateBundle Dec 7, 2019
@tivac tivac merged commit f2df7a8 into tivac:master Dec 7, 2019
@tivac
Copy link
Owner

tivac commented Dec 7, 2019

Released as [email protected]

@fuzetsu fuzetsu deleted the patch-1 branch December 8, 2019 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ongenerate hook is deprecated
2 participants