Allow reviewers to tell marvin to opt-in

[doronbehar]

Is there a typo in NixOS/nixpkgs#92152 (comment) ? Should I be part of the team?

[timokau]

Because only the PR author can opt-in for now. You don't need to be part of the reviewer team to opt-in, but you do need to be the author.

[doronbehar]

I see. Considering that now marvin is a bit new and perhaps not many people know about it, perhaps would it be better to allow anyone to tell marvin to opt-in? For my current usage, I really only find it useful to mark PRs I reviewed as ready so I'm only interested in the labels.

[timokau]

Well in a way opt-in is restricted to PR authors precisely because Marvin is so new. I want to carve out some little safe corner of nixpkgs to experiment, while affecting the rest of it as little as possible. That reduces the potential for bugs and for having people form negative opinions about it before it is finished.

Especially in the very beginning, it makes sense to restrict that "corner" to PRs where the author knows what is going on and what they are signing up for. Another reason is that I am still monitoring most interactions with marvin, and from that perspective the "organic" review cycles are just more interesting than a simple "opt-in -> needs_merger".

I might expand the beta at some point, but before that we will have to reach a point where continuous monitoring is less necessary and I will have to restrict my "merger rate-limit" (which is currently unlimited) and maybe find some other reviewers with commit permission. Until then, feel free to "convert" the PR author to opt-in themselves and maybe get on board with future PRs as well ;)