Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could Revise warn about "Method overwriting is not permitted during Module precompilation"? #889

Open
NHDaly opened this issue Feb 11, 2025 · 0 comments

Comments

@NHDaly
Copy link

NHDaly commented Feb 11, 2025

If you add a duplicate method to a package while a REPL is running Revise, you don't get any kind of warning from Revise.

So you could continue happily editing your project, not realizing you have a duplicate, and then be very surprised when you restart the REPL and it complains about the precompilation failure due to duplicate methods. You may even have forgotten about adding that method by the time you finally see the warning.

It would be nicer if we could give a warning right away, as soon as the duplicate was added.
Or even do the nice thing where Revise goes yellow until it's fixed?


My colleague @mabokhamis reports that they have a reproducible test failure that seems to be caused by duplicate methods, and our mutual colleague didn't understand the cause of the test failure until Mahmoud tried to reproduce it and noticed the precompile warnings.

It would be great if the original author had gotten a warning or error earlier! :)

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant