From a591356f6a094a031f38d303e0d4b5314ba25c02 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20F=C3=A9lix=20da=20Silva?= Date: Sat, 15 Jan 2022 01:26:46 -0400 Subject: [PATCH 1/3] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 9aaeb3b..4e4d66a 100644 --- a/README.md +++ b/README.md @@ -2083,7 +2083,7 @@ Drawable RenderLargeRectangles(Rectangle rectangles) { rectangle.SetWidth(4); rectangle.SetHeight(5); - var area = rectangle.GetArea(); // BAD: Will return 25 for Square. Should be 20. + var area = rectangle.GetArea(); // BAD: Will return 20 for Square. Should be 25. rectangle.Render(area); } } From 41455d64c5195fecfb6648eb3387bd9d1d4cd257 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20F=C3=A9lix=20da=20Silva?= Date: Sat, 15 Jan 2022 01:46:41 -0400 Subject: [PATCH 2/3] fix example of DRY --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 4e4d66a..9f3c7bf 100644 --- a/README.md +++ b/README.md @@ -2380,7 +2380,7 @@ Getting the abstraction right is critical, that's why you should follow the SOLI ```csharp public List ShowDeveloperList(Developers developers) { - foreach (var developers in developer) + foreach (var developer in developers) { var expectedSalary = developer.CalculateExpectedSalary(); var experience = developer.GetExperience(); @@ -2421,9 +2421,9 @@ public List ShowList(Employee employees) { foreach (var employee in employees) { - var expectedSalary = employees.CalculateExpectedSalary(); - var experience = employees.GetExperience(); - var githubLink = employees.GetGithubLink(); + var expectedSalary = employee.CalculateExpectedSalary(); + var experience = employee.GetExperience(); + var githubLink = employee.GetGithubLink(); var data = new[] { expectedSalary, From b48a537bb8dd93fab6e8cb10c8e2530f4388f43d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20F=C3=A9lix=20da=20Silva?= Date: Sat, 15 Jan 2022 14:34:42 -0400 Subject: [PATCH 3/3] change line 2086 on LSP --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 9f3c7bf..5ba8fcb 100644 --- a/README.md +++ b/README.md @@ -2083,7 +2083,7 @@ Drawable RenderLargeRectangles(Rectangle rectangles) { rectangle.SetWidth(4); rectangle.SetHeight(5); - var area = rectangle.GetArea(); // BAD: Will return 20 for Square. Should be 25. + var area = rectangle.GetArea(); // BAD: Will return 25 for Square. Should be 20. rectangle.Render(area); } }