Skip to content

Commit cd28486

Browse files
authored
Merge pull request rust-lang#303 from tgross35/rename-test-feature
Rename the `musl-reference-tests` feature to `musl-bitwise-tests`
2 parents 0e4cdba + a714d8d commit cd28486

File tree

5 files changed

+10
-8
lines changed

5 files changed

+10
-8
lines changed

CONTRIBUTING.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
in `src/lib.rs`.
88
- Write some simple tests in your module (using `#[test]`)
99
- Run `cargo test` to make sure it works
10-
- Run `cargo test --features libm-test/musl-reference-tests` to compare your
10+
- Run `cargo test --features libm-test/musl-bitwise-tests` to compare your
1111
implementation against musl's
1212
- Send us a pull request! Make sure to run `cargo fmt` on your code before
1313
sending the PR. Also include "closes #42" in the PR description to close the
@@ -88,7 +88,7 @@ If you'd like to run tests with randomized inputs that get compared against musl
8888
itself, you'll need to be on a Linux system and then you can execute:
8989

9090
```
91-
cargo test --features libm-test/musl-reference-tests
91+
cargo test --features libm-test/musl-bitwise-tests
9292
```
9393

9494
Note that you may need to pass `--release` to Cargo if there are errors related

ci/run.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,5 @@ $cmd --features 'unstable'
1717
$cmd --release --features 'unstable'
1818

1919
# also run the reference tests
20-
$cmd --features 'unstable libm-test/musl-reference-tests'
21-
$cmd --release --features 'unstable libm-test/musl-reference-tests'
20+
$cmd --features 'unstable libm-test/musl-bitwise-tests'
21+
$cmd --release --features 'unstable libm-test/musl-bitwise-tests'

crates/libm-test/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ default = []
99

1010
# Generate tests which are random inputs and the outputs are calculated with
1111
# musl libc.
12-
musl-reference-tests = ["rand"]
12+
musl-bitwise-tests = ["rand"]
1313

1414
[dependencies]
1515
libm = { path = "../.." }

crates/libm-test/build.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
fn main() {
2-
#[cfg(feature = "musl-reference-tests")]
2+
#[cfg(feature = "musl-bitwise-tests")]
33
musl_reference_tests::generate();
44
}
55

6-
#[cfg(feature = "musl-reference-tests")]
6+
#[cfg(feature = "musl-bitwise-tests")]
77
mod musl_reference_tests {
88
use rand::seq::SliceRandom;
99
use rand::Rng;

crates/libm-test/tests/musl_biteq.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1+
//! compare
2+
13
// PowerPC tests are failing on LLVM 13: https://github.com/rust-lang/rust/issues/88520
24
#[cfg(not(target_arch = "powerpc64"))]
3-
#[cfg(all(test, feature = "musl-reference-tests"))]
5+
#[cfg(all(test, feature = "musl-bitwise-tests"))]
46
include!(concat!(env!("OUT_DIR"), "/musl-tests.rs"));

0 commit comments

Comments
 (0)