Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Tag): migrate Tag component #1302

Merged
merged 6 commits into from
Nov 11, 2024
Merged

refactor(Tag): migrate Tag component #1302

merged 6 commits into from
Nov 11, 2024

Conversation

janseke10
Copy link
Contributor

@janseke10 janseke10 commented Oct 29, 2024 •
edited by eszthoff
Loading

ONEUI-454

Checklist

  • The Pull Request title follows our guidelines eg. feat(PrioritySelector): new component
  • Breaking changes are mentioned eg. BREAKING CHANGE: isMultiSelect prop is removed, if any.
  • Squash and Merge option is selected as merge option.

BREAKING CHANGE: Tag component's size prop is removed

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oneui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 0:34am

eszthoff
eszthoff suggested changes Oct 30, 2024
View reviewed changes
@eszthoff
Copy link
Contributor

eszthoff commented Nov 5, 2024

I found a bug that possibly was there already. If you use keyboard navigation, you cannot TAB beyond the delete button. The focus is stuck there. I think it is because of the preventDefault in line 71 or so.

@janseke10
style(Tag)!: improve styling and use of maxWidth
6c35eb9 
BREAKING CHANGE: 'size' is no longer a prop
@eszthoff
Copy link
Contributor

eszthoff commented Nov 6, 2024

LGTM but please add BREAKING CHANGES to the description and make sure it is copied to the squashed commit when merging.
Andre already changed the checklist for new PRs, so it will be clearer in the future. The checkboxes that aren't relevant can be removed here too :-)

@janseke10 janseke10 merged commit ef88a31 into master Nov 11, 2024
8 checks passed
@janseke10 janseke10 deleted the ONEUI-454--migrate-tag-component branch November 11, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eszthoff eszthoff eszthoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janseke10 @eszthoff