Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_*_virtual_machine - allow_extensions_operations can now be updated #7749

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

mbfrahry
Copy link
Member

Fixes #7070

@mbfrahry mbfrahry requested a review from a team July 14, 2020 20:45
@mbfrahry mbfrahry added this to the v2.19.0 milestone Jul 14, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbfrahry, LGTM 👍

@mbfrahry mbfrahry merged commit 801d1c5 into master Jul 15, 2020
@mbfrahry mbfrahry deleted the b-vm-allow-extension-operations branch July 15, 2020 00:42
mbfrahry added a commit that referenced this pull request Jul 15, 2020
allowExtensionOperations := d.Get("allow_extension_operations").(bool)

if !provisionVMAgent && allowExtensionOperations {
return fmt.Errorf("`allow_extension_operations` cannot be set to `true` when `provision_vm_agent` is set to `false`")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. provision_vm_agent affects the create process of a virtual machine.
Assume you did not install the agent (provision_vm_agent=false), then you can still install the agent manually

https://docs.microsoft.com/en-us/azure/virtual-machines/troubleshooting/install-vm-agent-offline

As far as I know, the manual installation does not affect provision_vm_agent value, but you can still use allow_extension_operations

@ghost
Copy link

ghost commented Jul 16, 2020

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_*_virtual_machine: Change of allow_extension_operations forces recreation which is wrong
3 participants