data source azurerm_dns_zone: make resource_group_name required

[njuCZ]

according to https://docs.microsoft.com/en-us/azure/dns/dns-zones-records#dns-zones, dns zone name is only unique in resource group. Different resource group could use the same dns zone name. it's not unique global.

So I think it does not make sense to search all resource group and return first found result.

[tombuildsstuff]

hey @njuCZ

Thanks for this PR.

Taking a look through here - whilst these can be unique per resource group, Terraform should still support looking these up - however Terraform should raise an error if multiple DNS Zones are found with the same name, would you be able to update this PR to fix this instead?

Thanks!

[njuCZ]

@tombuildsstuff I have modified this PR, please have a look again.

1. use listComplete rather than list all resource group and then ListByResourceGroup
2. when user does not specify resource_group_name, reports error if two dns zone have the same name
3. because resource group of dns zone is always lower case, change the test case to avoid check fail

[tombuildsstuff]

left a couple of comments but this otherwise LGTM 👍

[njuCZ]

@tombuildsstuff thanks for your suggestions. I have updated this PR, please have a look again

[tombuildsstuff]

otherwise LGTM 👍

[njuCZ]

@tombuildsstuff thanks for your suggestions. I have updated this function to return a pointer. in order to use the same variable resp and resourceGroup, I made a little change in the read func, please have a check

[jackofallops]

Tests passing:

[ghost]

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!