-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_kusto_cluster
- Support for optimized_auto_scale
#7371
azurerm_kusto_cluster
- Support for optimized_auto_scale
#7371
Conversation
38b19a7
to
a39f845
Compare
3b4a4f5
to
9782053
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR.
Taking a look through this mostly LGTM - there's a few changes needed here but if we can fix those up (and the tests pass) then this should otherwise be good to merge 👍
Thanks!
b41b329
to
d30451b
Compare
19e4861
to
184357f
Compare
e54d8f3
to
ffb220f
Compare
@tombuildsstuff Finally all acc tests are running: |
@tombuildsstuff Finally acceptance tests are running. Please review. make acctests SERVICE='kusto' TESTARGS='-run=TestAccAzureRMKustoCluster_optimizedAutoScale' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/kusto/tests/ -run=TestAccAzureRMKustoCluster_optimizedAutoScale -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMKustoCluster_optimizedAutoScale
=== PAUSE TestAccAzureRMKustoCluster_optimizedAutoScale
=== CONT TestAccAzureRMKustoCluster_optimizedAutoScale
--- PASS: TestAccAzureRMKustoCluster_optimizedAutoScale (1997.43s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/kusto/tests 1999.638s |
886e210
to
f17bb31
Compare
azurerm_kusto_cluster
- Support for optimized_auto_scale
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just made some minor changes with nil checks and a test fix
This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.18.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Enables the usage of the optimized auto scale feature of a Kusto Cluster.