azurerm_machine_learning_inference_cluster - support for the ssl.leaf_domain_label and ssl. overwrite_existing_domain properties

[gro1m]

Tasks:

• update resource to allow for leaf_domain_label using status 'Auto'
• add ConflictsWith to ssl block
• add tests
• update docs

[magodo]

Persumably should be:

Suggested change

	ConflictsWith: []string{"leaf_domain_label", "overwrite_existing_domain"},
	ConflictsWith: []string{"ssl.0.leaf_domain_label", "ssl.0.overwrite_existing_domain"},

[gro1m]

@magodo Yes you are right, but I do not understand why as the parameters are defined within the same block.

[magodo]

@gro1m Unfortunately this is how the resource data is implemented internally for now, as a map keyed by property addresses.

[gro1m]

Test summary (everything passes):

TF_ACC=1 go test -v ./azurerm/internal/services/machinelearning -run=TestAccInferenceCluster -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/05/24 10:44:22 [DEBUG] not using binary driver name, it's no longer needed
2021/05/24 10:44:23 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccInferenceCluster_basic
=== PAUSE TestAccInferenceCluster_basic
=== RUN   TestAccInferenceCluster_requiresImport
=== PAUSE TestAccInferenceCluster_requiresImport
=== RUN   TestAccInferenceCluster_completeCustomSSL
=== PAUSE TestAccInferenceCluster_completeCustomSSL
=== RUN   TestAccInferenceCluster_completeMicrosoftSSL
=== PAUSE TestAccInferenceCluster_completeMicrosoftSSL
=== RUN   TestAccInferenceCluster_completeProduction
=== PAUSE TestAccInferenceCluster_completeProduction
=== CONT  TestAccInferenceCluster_basic
=== CONT  TestAccInferenceCluster_requiresImport
=== CONT  TestAccInferenceCluster_completeProduction
=== CONT  TestAccInferenceCluster_completeMicrosoftSSL
=== CONT  TestAccInferenceCluster_completeCustomSSL
--- PASS: TestAccInferenceCluster_requiresImport (836.13s)
--- PASS: TestAccInferenceCluster_completeCustomSSL (898.38s)
--- PASS: TestAccInferenceCluster_completeProduction (942.92s)
--- PASS: TestAccInferenceCluster_basic (952.25s)
--- PASS: TestAccInferenceCluster_completeMicrosoftSSL (952.58s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/machinelearning     957.866s

[katbyte]

Thanks @gro1m - LGTM 🚀

[ghost]

This has been released in version 2.62.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.62.0"
}
# ... other configuration ...

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.