Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: no longer auto register the Microsoft.DevSpaces RP #11822

Merged
merged 3 commits into from
May 26, 2021
Merged

provider: no longer auto register the Microsoft.DevSpaces RP #11822

merged 3 commits into from
May 26, 2021

Conversation

kuwas
Copy link
Contributor

@kuwas kuwas commented May 21, 2021

Summary

Notes

@ghost ghost added the size/XS label May 21, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @kuwas

Thanks for this PR.

Taking a look through here whilst removing the RP from being registered automatically looks good - removing these resources prior to 3.0 would be a breaking change, as such we need to leave those in for the moment. As such if we can add the Service Package registration back in then this should otherwise be good to merge 👍

Thanks!

@kuwas kuwas requested a review from tombuildsstuff May 26, 2021 14:15
@katbyte katbyte added this to the v2.61.0 milestone May 26, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@katbyte katbyte merged commit 4e530f3 into hashicorp:master May 26, 2021
@katbyte katbyte changed the title fix(devspaces): remove devspaces provider auto-registration provider: no longer auto register the Microsoft.DevSpaces RP May 26, 2021
katbyte added a commit that referenced this pull request May 26, 2021
@ghost
Copy link

ghost commented May 27, 2021

This has been released in version 2.61.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.61.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG > Microsoft.DevSpaces provider auto-registration fails
3 participants