Skip to content

Commit ec7dc7a

Browse files
committedAug 5, 2023
refactor: replace cloneXXX with generics function cloneSlice
1 parent 490ffb5 commit ec7dc7a

File tree

2 files changed

+3
-22
lines changed

2 files changed

+3
-22
lines changed
 

‎client.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -1443,9 +1443,9 @@ func (c *Client) Clone() *Client {
14431443
cc.PathParams = cloneMap(c.PathParams)
14441444
cc.QueryParams = cloneUrlValues(c.QueryParams)
14451445
cc.FormData = cloneUrlValues(c.FormData)
1446-
cc.beforeRequest = cloneRequestMiddleware(c.beforeRequest)
1447-
cc.udBeforeRequest = cloneRequestMiddleware(c.udBeforeRequest)
1448-
cc.afterResponse = cloneResponseMiddleware(c.afterResponse)
1446+
cc.beforeRequest = cloneSlice(c.beforeRequest)
1447+
cc.udBeforeRequest = cloneSlice(c.udBeforeRequest)
1448+
cc.afterResponse = cloneSlice(c.afterResponse)
14491449
cc.dumpOptions = c.dumpOptions.Clone()
14501450
cc.retryOption = c.retryOption.Clone()
14511451
return &cc

‎req.go

-19
Original file line numberDiff line numberDiff line change
@@ -93,25 +93,6 @@ func cloneSlice[T any](s []T) []T {
9393
return ss
9494
}
9595

96-
// TODO: change to generics function when generics are commonly used.
97-
func cloneRequestMiddleware(m []RequestMiddleware) []RequestMiddleware {
98-
if len(m) == 0 {
99-
return nil
100-
}
101-
mm := make([]RequestMiddleware, len(m))
102-
copy(mm, m)
103-
return mm
104-
}
105-
106-
func cloneResponseMiddleware(m []ResponseMiddleware) []ResponseMiddleware {
107-
if len(m) == 0 {
108-
return nil
109-
}
110-
mm := make([]ResponseMiddleware, len(m))
111-
copy(mm, m)
112-
return mm
113-
}
114-
11596
func cloneUrlValues(v url.Values) url.Values {
11697
if v == nil {
11798
return nil

0 commit comments

Comments
 (0)