Skip to content

Commit c864dea

Browse files
authoredFeb 25, 2025··
lib: unexpose six process bindings
Namely: async_wrap, crypto, http_parser, signal_wrap, url, and v8. They were runtime-deprecated 4 years ago. PR-URL: nodejs#57149 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 6cb0690 commit c864dea

File tree

4 files changed

+4
-23
lines changed

4 files changed

+4
-23
lines changed
 

‎lib/internal/bootstrap/realm.js

+1-6
Original file line numberDiff line numberDiff line change
@@ -112,12 +112,7 @@ const processBindingAllowList = new SafeSet([
112112
]);
113113

114114
const runtimeDeprecatedList = new SafeSet([
115-
'async_wrap',
116-
'crypto',
117-
'http_parser',
118-
'signal_wrap',
119-
'url',
120-
'v8',
115+
// The list of runtime-deprecated bindings is currently empty.
121116
]);
122117

123118
const legacyWrapperList = new SafeSet([

‎test/fixtures/permission/processbinding.js

-8
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,6 @@ const assert = require('assert');
1515
}));
1616
}
1717

18-
{
19-
assert.throws(() => {
20-
process.binding('async_wrap');
21-
}, common.expectsError({
22-
code: 'ERR_ACCESS_DENIED',
23-
}));
24-
}
25-
2618
{
2719
assert.throws(() => {
2820
process.binding('fs');

‎test/parallel/test-http-parser-timeout-reset.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1+
// Flags: --expose-internals
12
'use strict';
23
const common = require('../common');
34

45
const net = require('net');
5-
const { HTTPParser } = process.binding('http_parser');
6+
const { internalBinding } = require('internal/test/binding');
7+
const { HTTPParser } = internalBinding('http_parser');
68

79
const server = net.createServer((socket) => {
810
socket.write('HTTP/1.1 200 OK\r\n');

‎test/parallel/test-process-binding-internalbinding-allowlist.js

-8
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,12 @@ const assert = require('assert');
66

77
// Assert that allowed internalBinding modules are accessible via
88
// process.binding().
9-
assert(process.binding('async_wrap'));
109
assert(process.binding('buffer'));
1110
assert(process.binding('cares_wrap'));
1211
assert(process.binding('constants'));
1312
assert(process.binding('contextify'));
14-
if (common.hasCrypto) { // eslint-disable-line node-core/crypto-check
15-
assert(process.binding('crypto'));
16-
}
1713
assert(process.binding('fs'));
1814
assert(process.binding('fs_event_wrap'));
19-
assert(process.binding('http_parser'));
2015
if (common.hasIntl) {
2116
assert(process.binding('icu'));
2217
}
@@ -25,7 +20,6 @@ assert(process.binding('js_stream'));
2520
assert(process.binding('natives'));
2621
assert(process.binding('os'));
2722
assert(process.binding('pipe_wrap'));
28-
assert(process.binding('signal_wrap'));
2923
assert(process.binding('spawn_sync'));
3024
assert(process.binding('stream_wrap'));
3125
assert(process.binding('tcp_wrap'));
@@ -34,8 +28,6 @@ if (common.hasCrypto) { // eslint-disable-line node-core/crypto-check
3428
}
3529
assert(process.binding('tty_wrap'));
3630
assert(process.binding('udp_wrap'));
37-
assert(process.binding('url'));
3831
assert(process.binding('util'));
3932
assert(process.binding('uv'));
40-
assert(process.binding('v8'));
4133
assert(process.binding('zlib'));

0 commit comments

Comments
 (0)
Please sign in to comment.