Add comments

strongoier · strongoier · commit c1f1674ad290 · 2022-09-13T21:29:35.000+08:00
diff --git a/taichi/codegen/cuda/codegen_cuda.cpp b/taichi/codegen/cuda/codegen_cuda.cpp
@@ -663,6 +663,8 @@ class TaskCodeGenCUDA : public TaskCodeGenLLVM {
         TI_NOT_IMPLEMENTED
       }
     } else {
+      // Note that ret_type here cannot be integral because pow with an
+      // integral exponent has been demoted in the demote_operations pass
       if (ret_type->is_primitive(PrimitiveTypeID::f32)) {
         llvm_val[stmt] = create_call("__nv_powf", {lhs, rhs});
       } else if (ret_type->is_primitive(PrimitiveTypeID::f64)) {
diff --git a/taichi/codegen/llvm/codegen_llvm.cpp b/taichi/codegen/llvm/codegen_llvm.cpp
@@ -658,6 +658,8 @@ void TaskCodeGenLLVM::visit(BinaryOpStmt *stmt) {
       }
     } else if (op == BinaryOpType::pow) {
       if (arch_is_cpu(current_arch())) {
+        // Note that ret_type here cannot be integral because pow with an
+        // integral exponent has been demoted in the demote_operations pass
         if (ret_type->is_primitive(PrimitiveTypeID::f32)) {
           llvm_val[stmt] = create_call("pow_f32", {lhs, rhs});
         } else if (ret_type->is_primitive(PrimitiveTypeID::f64)) {

Original file line number	Diff line number	Diff line change
`@@ -663,6 +663,8 @@ class TaskCodeGenCUDA : public TaskCodeGenLLVM {`
`663`	`663`	`TI_NOT_IMPLEMENTED`
`664`	`664`	`}`
`665`	`665`	`} else {`
	`666`	`+ // Note that ret_type here cannot be integral because pow with an`
	`667`	`+ // integral exponent has been demoted in the demote_operations pass`
`666`	`668`	`if (ret_type->is_primitive(PrimitiveTypeID::f32)) {`
`667`	`669`	`llvm_val[stmt] = create_call("__nv_powf", {lhs, rhs});`
`668`	`670`	`} else if (ret_type->is_primitive(PrimitiveTypeID::f64)) {`
Original file line number	Diff line number	Diff line change
`@@ -658,6 +658,8 @@ void TaskCodeGenLLVM::visit(BinaryOpStmt *stmt) {`
`658`	`658`	`}`
`659`	`659`	`} else if (op == BinaryOpType::pow) {`
`660`	`660`	`if (arch_is_cpu(current_arch())) {`
	`661`	`+ // Note that ret_type here cannot be integral because pow with an`
	`662`	`+ // integral exponent has been demoted in the demote_operations pass`
`661`	`663`	`if (ret_type->is_primitive(PrimitiveTypeID::f32)) {`
`662`	`664`	`llvm_val[stmt] = create_call("pow_f32", {lhs, rhs});`
`663`	`665`	`} else if (ret_type->is_primitive(PrimitiveTypeID::f64)) {`