Skip to content

Commit af8b5fd

Browse files
committed
[SymForce-External] Delete pylint
Delete pylint Move everything to ruff Topic: rm-pylint Closes #411 GitOrigin-RevId: de95bf10f605b03ad0f3962dd02e0ed952944efe
1 parent eaf147a commit af8b5fd

File tree

137 files changed

+604
-1282
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

137 files changed

+604
-1282
lines changed

Makefile

+5-7
Original file line numberDiff line numberDiff line change
@@ -53,21 +53,19 @@ check_types:
5353
--exclude "symforce/examples/.*/gen/python2\.7/lcmtypes" \
5454
--exclude third_party
5555

56-
# Run pylint on the symforce package, and tests
57-
# TODO(aaron): Also run on other python code in symforce. Generated code will require a different
58-
# config since it is py6 and contains a lot of duplicate code
59-
pylint:
60-
$(PYTHON) -m pylint symforce test/*.py
56+
# Run ruff check
57+
ruff_check:
58+
ruff check
6159

6260
# Lint check for formatting and type hints
6361
# This needs pass before any merge.
64-
lint: check_types check_format pylint
62+
lint: check_types check_format ruff_check
6563

6664
# Clean all artifacts
6765
clean: docs_clean coverage_clean
6866
rm -rf $(BUILD_DIR)
6967

70-
.PHONY: all reqs format check_format check_types pylint lint clean
68+
.PHONY: all reqs format check_format check_types ruff_check lint clean
7169

7270
# -----------------------------------------------------------------------------
7371
# Tests

dev_requirements.txt

+2-23
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ argh==0.31.2
1515
# via
1616
# skymarshal
1717
# symforce (setup.py)
18-
astroid==2.15.8
19-
# via pylint
2018
asttokens==2.4.1
2119
# via stack-data
2220
attrs==23.2.0
@@ -63,8 +61,6 @@ decorator==5.1.1
6361
# via ipython
6462
defusedxml==0.7.1
6563
# via nbconvert
66-
dill==0.3.8
67-
# via pylint
6864
docutils==0.20.1
6965
# via
7066
# breathe
@@ -103,8 +99,6 @@ ipython==8.12.3
10399
# via ipykernel
104100
ipython-genutils==0.2.0
105101
# via symforce (setup.py)
106-
isort==5.13.2
107-
# via pylint
108102
jedi==0.19.1
109103
# via ipython
110104
jinja2==3.1.4
@@ -134,8 +128,6 @@ jupyterlab-pygments==0.3.0
134128
# via nbconvert
135129
kiwisolver==1.4.5
136130
# via matplotlib
137-
lazy-object-proxy==1.10.0
138-
# via astroid
139131
llvmlite==0.41.1
140132
# via numba
141133
markdown-it-py==3.0.0
@@ -152,8 +144,6 @@ matplotlib-inline==0.1.7
152144
# via
153145
# ipykernel
154146
# ipython
155-
mccabe==0.7.0
156-
# via pylint
157147
mdit-py-plugins==0.4.1
158148
# via myst-parser
159149
mdurl==0.1.2
@@ -221,9 +211,7 @@ pip-tools==7.4.1
221211
pkgutil-resolve-name==1.3.10
222212
# via jsonschema
223213
platformdirs==4.2.2
224-
# via
225-
# jupyter-core
226-
# pylint
214+
# via jupyter-core
227215
plotly==5.22.0
228216
# via symforce (setup.py)
229217
ply==3.11
@@ -244,8 +232,6 @@ pygments==2.18.0
244232
# ipython
245233
# nbconvert
246234
# sphinx
247-
pylint==2.17.7
248-
# via symforce (setup.py)
249235
pyparsing==3.1.2
250236
# via matplotlib
251237
pyproject-hooks==1.1.0
@@ -277,7 +263,7 @@ rpds-py==0.18.1
277263
# via
278264
# jsonschema
279265
# referencing
280-
ruff==0.5.4
266+
ruff==0.7.1
281267
# via symforce (setup.py)
282268
scipy==1.10.1
283269
# via symforce (setup.py)
@@ -335,9 +321,6 @@ tomli==2.0.1
335321
# build
336322
# mypy
337323
# pip-tools
338-
# pylint
339-
tomlkit==0.12.5
340-
# via pylint
341324
tornado==6.4
342325
# via
343326
# ipykernel
@@ -364,10 +347,8 @@ types-setuptools==69.5.0.20240513
364347
# via symforce (setup.py)
365348
typing-extensions==4.11.0
366349
# via
367-
# astroid
368350
# ipython
369351
# mypy
370-
# pylint
371352
tzdata==2024.1
372353
# via pandas
373354
urllib3==2.2.1
@@ -384,8 +365,6 @@ wheel==0.43.0
384365
# via
385366
# pip-tools
386367
# symforce (setup.py)
387-
wrapt==1.16.0
388-
# via astroid
389368
zipp==3.18.1
390369
# via
391370
# importlib-metadata

docs/conf.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
# -- Project information -----------------------------------------------------
2828

2929
project = "symforce"
30-
copyright = "2022, Skydio, Inc"
30+
copyright = "2022, Skydio, Inc" # noqa: A001
3131
author = "Skydio"
3232

3333
# The short X.Y version

gen/python/sym/atan_camera_cal.py

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/sym/double_sphere_camera_cal.py

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/sym/equirectangular_camera_cal.py

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/sym/linear_camera_cal.py

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/sym/ops/atan_camera_cal/camera_ops.py

+3-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/sym/ops/atan_camera_cal/group_ops.py

+3-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/sym/ops/atan_camera_cal/lie_group_ops.py

+3-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/sym/ops/double_sphere_camera_cal/camera_ops.py

+3-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/sym/ops/double_sphere_camera_cal/group_ops.py

+3-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/sym/ops/double_sphere_camera_cal/lie_group_ops.py

+3-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/sym/ops/equirectangular_camera_cal/camera_ops.py

+3-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/sym/ops/equirectangular_camera_cal/group_ops.py

+3-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/sym/ops/equirectangular_camera_cal/lie_group_ops.py

+3-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/sym/ops/linear_camera_cal/camera_ops.py

+3-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gen/python/sym/ops/linear_camera_cal/group_ops.py

+3-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)