[SymForce] DataBuffers not marked as unused

Topic: sf-databuffer-unused
Reviewers: nathan,bradley,harrison,chao,hayk
GitOrigin-RevId: 2d99b927990463cbbfd2a1be29c20b9d9713334d

Author: aaron-skydio

symforce/codegen/codegen.py

@@ -394,7 +394,11 @@ def unused_arguments(self) -> T.List[str]:
         """
         results = []
         for input_name, input_value in self.inputs.items():
-            input_symbols = set(ops.StorageOps.to_storage(input_value))
+            if isinstance(input_value, sf.DataBuffer):
+                # DataBuffers have no storage, so we look for their exact symbol
+                input_symbols = {input_value}
+            else:
+                input_symbols = set(ops.StorageOps.to_storage(input_value))
             if not input_symbols.intersection(self.output_symbols):
                 results.append(input_name)
         return results

test/symforce_function_codegen_test_data/symengine/databuffer_codegen_test_data/cpp/symforce/buffer_test/buffer_func.h

@@ -25,9 +25,6 @@ template <typename Scalar>
 Scalar BufferFunc(const Scalar* const buffer, const Scalar a, const Scalar b) {
   // Total ops: 8
 
-  // Unused inputs
-  (void)buffer;
-
   // Input arrays
 
   // Intermediate terms (1)

test/symforce_function_codegen_test_data/sympy/databuffer_codegen_test_data/cpp/symforce/buffer_test/buffer_func.h

@@ -25,9 +25,6 @@ template <typename Scalar>
 Scalar BufferFunc(const Scalar* const buffer, const Scalar a, const Scalar b) {
   // Total ops: 9
 
-  // Unused inputs
-  (void)buffer;
-
   // Input arrays
 
   // Intermediate terms (0)