Skip to content

Commit 40a6c9e

Browse files
brian-kubisiak-skydioaaron-skydio
authored andcommitted
[SymForce] Pull in the latest tl::optional
When compiling with -Werror=extra, the symforce build fails with: _deps/tl_optional-src/include/tl/optional.hpp:455:3: error: base class 'struct tl::detail::optional_operations_base<sym::Linearization<double> >' should be explicitly initialized in the copy constructor [-Werror=extra] 455 | optional_copy_base(const optional_copy_base &rhs) { | ^~~~~~~~~~~~~~~~~~ cc1plus: all warnings being treated as errors This was fixed upstream in TartanLlama/optional#45, which is not yet in any tagged release. Bump the version of tl::optional used by symforce to pull in this fix. Signed-off-by: Brian Kubisiak GitOrigin-RevId: b5b0802e8da8e2099980cc5a60674c9365367ac3
1 parent c163cb6 commit 40a6c9e

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

symforce/opt/CMakeLists.txt

+3-2
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,12 @@ find_package(tl-optional QUIET)
6363
if (NOT tl_optional_FOUND)
6464
message(STATUS "tl::optional not found, adding with FetchContent")
6565
function(add_tl_optional)
66-
set(OPTIONAL_ENABLE_TESTS OFF CACHE INTERNAL "tl::optional shouldn't build tests")
66+
set(OPTIONAL_BUILD_TESTS OFF CACHE INTERNAL "tl::optional shouldn't build tests")
6767
FetchContent_Declare(
6868
tl_optional
6969
GIT_REPOSITORY https://github.com/TartanLlama/optional
70-
GIT_TAG v1.0.0
70+
# NOTE: This pulls in TartanLlama/optional#45, which is not yet in any tagged releases.
71+
GIT_TAG c28fcf74d207fc667c4ed3dbae4c251ea551c8c1
7172
GIT_SHALLOW TRUE
7273
)
7374
FetchContent_MakeAvailable(tl_optional)

0 commit comments

Comments
 (0)