Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace Symbol command should accept an empty query string, since 3.15 #1008

Closed
genericptr opened this issue May 2, 2020 · 2 comments · Fixed by #2071
Closed

Workspace Symbol command should accept an empty query string, since 3.15 #1008

genericptr opened this issue May 2, 2020 · 2 comments · Fixed by #2071
Labels
enhancement protocol updates Issues related to changes in the LSP protocol. Usually because we're out-of-date.

Comments

@genericptr
Copy link

The "LSP: Workspace Symbol" command currently requires you enter a query string before receiving any results and thus the command does not function similar to the built-in "Find Symbol in Project" command.

It is my understanding of the LSP that Workspace Symbol is basically "Goto Symbol in Project" so it should (at least by way of option) allow an empty query string so that it can be implemented in this way.

The spec also allows this according to the comment below:

/**
 * The parameters of a Workspace Symbol Request.
 */
interface WorkspaceSymbolParams extends WorkDoneProgressParams, PartialResultParams {
	/**
	 * A query string to filter symbols by. Clients may send an empty
	 * string here to request all symbols.
	 */
	query: string;
}
@rwols rwols added enhancement protocol updates Issues related to changes in the LSP protocol. Usually because we're out-of-date. labels May 5, 2020
@rwols rwols changed the title Workspace Symbol command should accept accept empty strings Workspace Symbol command should accept an empty query string, as per 3.15 Jul 22, 2020
@rwols rwols changed the title Workspace Symbol command should accept an empty query string, as per 3.15 Workspace Symbol command should accept an empty query string, since 3.15 Jul 22, 2020
@rwols
Copy link
Member

rwols commented Sep 16, 2020

Pretty much blocked on sublimehq/sublime_text#3338

@genericptr
Copy link
Author

It's been so long I forget now, but completion panels now work with partial results so is there anything new that would allow symbols to be recalculated as you type? Workspace Symbols are basically dead in the water until that is possible. Sending empty strings is actually the smaller of the 2 issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement protocol updates Issues related to changes in the LSP protocol. Usually because we're out-of-date.
Projects
None yet
2 participants