-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http auth to static warm #7115
Add http auth to static warm #7115
Conversation
|
Oh I like this one, nicely done |
Nice one! The convention for command line arguments is to use full words with double dashes, and short (often single letter) with single dashes. So instead of |
Thanks @arthurperton for pointing this out! I adjusted the arguments in order to comply with the convention. Other commands in this repository generally use full words for the arguments, therefore I also used this form here. |
Nice 👌🏻 |
You could add shortcuts if you want. https://laravel.com/docs/9.x/artisan#option-shortcuts e.g.
|
Problem:
Staging systems are often behind a HTTP basic authentication. Calling the current static warm command on a site behind HTTP basic authentication (e.g. from a CI job) produces a "401 Authorization Required" error.
Solution:
This pull request adds the possibility to pass the authentication credentials via the parameters
--u
(HTTP authentication user) and--p
(HTTP authentication password) to the static warm command.