Skip to content
This repository was archived by the owner on Oct 7, 2023. It is now read-only.

notifier.js needs a version number, and should be published #11

Open
jbatte47 opened this issue Sep 19, 2012 · 5 comments
Open

notifier.js needs a version number, and should be published #11

jbatte47 opened this issue Sep 19, 2012 · 5 comments

Comments

@jbatte47
Copy link

This library is too cool not to be on cdnjs.com, and nuget.org. I am very tempted to put them there myself and just attribute you as the author, but I would need to assign a version number in both cases. I guess I would just go with 1.0.0 in lieu of a realistic value... please advise. If I get impatient and publish all this stuff and it turns out you want control, I will gladly hand everything over.

Thanks

@sri-rang
Copy link
Owner

Sure lets do it.

Feel free to send me a pull request, or I'll do this early next week when I'm back from my travels.

@jbatte47
Copy link
Author

I'll have a pull request ready to go by tomorrow; as of right now I'm planning on adding a version number to the js file, and creating a notifier.js.nuspec for NuGet integration. This Page shows how to publish packages. It's pretty straightforward. So is cdnjs.com; they are right next door. Let me know if you'd like assistance with any of it.

@jbatte47
Copy link
Author

jbatte47 commented Oct 1, 2012

Hey, sorry I flaked out on you there. A lot came up on very short notice. I see that you've marked a 1.0.0 branch; that's great! I'm going to send it in to cdnjs.com. Again, let me know if you need assistance with the NuGet portion.

@sri-rang
Copy link
Owner

sri-rang commented Oct 1, 2012

I'm working on a jQuery less release. Should we wait for that before 'releasing' it on cdnjs?

@jbatte47
Copy link
Author

jbatte47 commented Oct 6, 2012

Well the way I see it, since cdnjs is versioned, you can roll out as many editions of notifier.js as you like. Personally, I use the 1.0.0.0 version in a few places and I'd love to have my refs to that library come from a cdn, so I'm going to send them a pull request with 1.0.0.0 in it; you could always roll out your version sans jQuery later with a greater version number and there won't be any conflicts :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants