Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Enhance the UX when restoring postgres db #216

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

dpordomingo
Copy link
Contributor

sourced restart is slower than just waking up the new DB container, and loading the dashboards.
(especially when developing, when the user might be interested in keeping the current container)

@dpordomingo dpordomingo added the enhancement New feature or request label Aug 16, 2019
@dpordomingo dpordomingo requested a review from a team August 16, 2019 18:06
@dpordomingo dpordomingo self-assigned this Aug 16, 2019
@dpordomingo dpordomingo changed the title Enhance the UX when restoring postgres db [DOCS] Enhance the UX when restoring postgres db Aug 16, 2019
@dpordomingo
Copy link
Contributor Author

Feel free to directly close this PR if this is going to be fully addressed by the new update command
(we don't have its specs yet)

@carlosms
Copy link
Contributor

To me it seems a bit too low level for end users FAQ. It's nice that a developer can do that, but for end users we already have restart, even if it is slower.
Even more, we already have sourced prune and init again for this use case. I think it makes more sense to move to this direction (sourced commands) when possible for end-user docs.

@dpordomingo
Copy link
Contributor Author

I see your point, and it's totally legit. But we're already explaining how to restore the dashboards using advanced commands like dropping volumes... Why not continuing improving the user experience in that direction?

Would it be better if we move this advanced commands deeper in the docs? Or what if we let sourced handle this feature internally?

@se7entyse7en
Copy link
Contributor

I agree with @carlosms that it would be better to show how-tos using sourced commands whenever it's possible.

Regarding this specific use-case, maybe we could provide a sourced reset command that works as a reset to factory defaults. So this would do a sourced prune and a restore of the default charts for the current version.

@dpordomingo
Copy link
Contributor Author

Prune and init would not satisfy the same usecase, because it does not keep repos, metada nor indexes.

From my pov, we should consider if the usecase is legit: if it is, try to improve the current experience, or provide a better way; if it is not alegit usecase, drop it from the docs.

Maybe @src-d/product could confirm if restoring the UI state is a feature that we want to provide.

@smacker
Copy link
Contributor

smacker commented Aug 20, 2019

These commands are needed only for development.
Prune+init covers all the user needs for reset.
Let's move it into contributing document instead or just remove.

@dpordomingo
Copy link
Contributor Author

Moving it to CONTRIBUTING might be a good solution. Thanks for suggesting.

@dpordomingo
Copy link
Contributor Author

'sourced restart' is slower than just waking up the new DB container,g
and loading the dashboards

Signed-off-by: David Pordomingo <[email protected]>
@dpordomingo dpordomingo merged commit 1eeef6d into src-d:master Sep 10, 2019
@dpordomingo dpordomingo deleted the restart-dashboards branch September 10, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants