Skip to content

feat(ci): add Windows signing process for executable in build workflow #3417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 19, 2025

Conversation

afonsojramos
Copy link
Member

This pull request introduces changes to the GitHub Actions workflow configuration in .github/workflows/build.yml, focusing on adding a signing process for Windows executables and commenting out the release-triggering job for Homebrew and AUR. Below is a breakdown of the key changes:

Windows executable signing:

  • Added steps to upload unsigned Windows executables as artifacts, submit them for signing via SignPath, and copy back the signed executables. These steps are conditionally executed only for Windows builds.

@afonsojramos afonsojramos requested a review from rxri May 19, 2025 15:37
@rxri rxri merged commit 41ed718 into spicetify:main May 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants