Skip to content

fix(install/linux): properly parse --root flag and tag option #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 6, 2024

Conversation

rxri
Copy link
Member

@rxri rxri commented Mar 31, 2024

No description provided.

@rxri rxri force-pushed the fix/install/linux branch from ed27287 to 1fd2b6f Compare March 31, 2024 18:44
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this flag for? We have no documentation for it anywhere.

@rxri
Copy link
Member Author

rxri commented Apr 1, 2024

What is this flag for? We have no documentation for it anywhere.

@afonsojramos how is it not documented...
image

@afonsojramos
Copy link
Member

Well, fair. I just meant that we don't show it in any --help command, and that we don't have it in the docs. But I suppose that for this case that is sort of the goal, as it is an exception to the rule.

@rxri
Copy link
Member Author

rxri commented Apr 1, 2024

Well yeah, it's intended tbh.

@rxri rxri requested a review from afonsojramos April 2, 2024 13:04
@rxri rxri requested a review from theRealPadster April 6, 2024 13:52
@rxri rxri merged commit 1d9de3a into master Apr 6, 2024
@rxri rxri deleted the fix/install/linux branch April 6, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants