Skip to content

Commit 0ab90c2

Browse files
committed
fix: re-render lyrics div when Translation Display is changed
1 parent afd98f4 commit 0ab90c2

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

CustomApps/lyrics-plus/OptionsMenu.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,14 @@ const TranslationMenu = react.memo(({ friendlyLanguage, hasTranslation }) => {
165165
renderInline: true,
166166
},
167167
{
168-
desc: "Display",
168+
desc: "Translation Display",
169169
key: "translate:display-mode",
170170
type: ConfigSelection,
171+
onChange: (name, value) => {
172+
CONFIG.visual[name] = value;
173+
localStorage.setItem(`${APP_NAME}:visual:${name}`, value);
174+
lyricContainerUpdate?.();
175+
},
171176
options: translationDisplayOptions,
172177
defaultValue: savedTranslationDisplay,
173178
renderInline: true,

jsHelper/expFeatures.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@
167167
isFallback = false;
168168
notice.remove();
169169
remoteConfiguration =
170-
Spicetify?.RemoteConfigResolver.value?.remoteConfiguration ?? (await Spicetify.Platform?.RemoteConfigDebugAPI.getProperties());
170+
Spicetify?.RemoteConfigResolver?.value.remoteConfiguration ?? (await Spicetify.Platform?.RemoteConfigDebugAPI.getProperties());
171171
})();
172172

173173
for (const key of Object.keys(overrideList)) {

0 commit comments

Comments
 (0)