Skip to content

Commit e463ee8

Browse files
committed
Father, forgive me, for I am adding inline types. (#266)
* Father, forgive me, for I am adding inline types. * chore: sort imports
1 parent 4a170cd commit e463ee8

17 files changed

+75
-330
lines changed

robyn/__init__.py

+22-22
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,17 @@
33
import multiprocessing as mp
44
import os
55
import sys
6+
from typing import Callable, Optional
67

78
from multiprocess import Process
89
from watchdog.observers import Observer
9-
from robyn.events import Events
10+
1011
from robyn.argument_parser import ArgumentParser
1112
from robyn.dev_event_handler import EventHandler
13+
from robyn.events import Events
1214
from robyn.log_colors import Colors
1315
from robyn.processpool import spawn_process
1416
from robyn.responses import jsonify, static_file
15-
1617
from robyn.robyn import SocketHeld
1718
from robyn.router import MiddlewareRouter, Router, WebSocketRouter
1819
from robyn.ws import WS
@@ -23,7 +24,7 @@
2324
class Robyn:
2425
"""This is the python wrapper for the Robyn binaries."""
2526

26-
def __init__(self, file_object):
27+
def __init__(self, file_object: str) -> None:
2728
directory_path = os.path.dirname(os.path.abspath(file_object))
2829
self.file_path = file_object
2930
self.directory_path = directory_path
@@ -54,7 +55,7 @@ def _add_route(self, route_type, endpoint, handler, const=False):
5455
"""
5556
self.router.add_route(route_type, endpoint, handler, const)
5657

57-
def before_request(self, endpoint):
58+
def before_request(self, endpoint: str) -> Callable[..., None]:
5859
"""
5960
The @app.before_request decorator to add a get route
6061
@@ -63,7 +64,7 @@ def before_request(self, endpoint):
6364

6465
return self.middleware_router.add_before_request(endpoint)
6566

66-
def after_request(self, endpoint):
67+
def after_request(self, endpoint: str) -> Callable[..., None]:
6768
"""
6869
The @app.after_request decorator to add a get route
6970
@@ -73,31 +74,31 @@ def after_request(self, endpoint):
7374
return self.middleware_router.add_after_request(endpoint)
7475

7576
def add_directory(
76-
self, route, directory_path, index_file=None, show_files_listing=False
77+
self, route: str, directory_path: str, index_file: Optional[str] = None, show_files_listing: bool = False
7778
):
7879
self.directories.append((route, directory_path, index_file, show_files_listing))
7980

80-
def add_header(self, key, value):
81+
def add_header(self, key: str, value: str) -> None:
8182
self.headers.append((key, value))
8283

83-
def add_web_socket(self, endpoint, ws):
84+
def add_web_socket(self, endpoint: str, ws: WS) -> None:
8485
self.web_socket_router.add_route(endpoint, ws)
8586

86-
def _add_event_handler(self, event_type: str, handler):
87+
def _add_event_handler(self, event_type: str, handler) -> None:
8788
logger.debug(f"Add event {event_type} handler")
8889
if event_type not in {Events.STARTUP, Events.SHUTDOWN}:
8990
return
9091

9192
is_async = asyncio.iscoroutinefunction(handler)
9293
self.event_handlers[event_type] = (handler, is_async)
9394

94-
def startup_handler(self, handler):
95+
def startup_handler(self, handler: Callable) -> None:
9596
self._add_event_handler(Events.STARTUP, handler)
9697

97-
def shutdown_handler(self, handler):
98+
def shutdown_handler(self, handler: Callable) -> None:
9899
self._add_event_handler(Events.SHUTDOWN, handler)
99100

100-
def start(self, url="127.0.0.1", port=5000):
101+
def start(self, url: str = "127.0.0.1", port: int = 5000):
101102
"""
102103
Starts the server
103104
@@ -157,7 +158,6 @@ def init_processpool(socket):
157158
logger.info(f"{Colors.BOLD}{Colors.OKGREEN} Terminating server!! {Colors.ENDC}")
158159
for process in process_pool:
159160
process.kill()
160-
161161
else:
162162
event_handler = EventHandler(self.file_path)
163163
event_handler.start_server_first_time()
@@ -174,7 +174,7 @@ def init_processpool(socket):
174174
observer.stop()
175175
observer.join()
176176

177-
def get(self, endpoint, const=False):
177+
def get(self, endpoint: str, const: bool = False) -> Callable[..., None]:
178178
"""
179179
The @app.get decorator to add a get route
180180
@@ -186,7 +186,7 @@ def inner(handler):
186186

187187
return inner
188188

189-
def post(self, endpoint):
189+
def post(self, endpoint: str) -> Callable[..., None]:
190190
"""
191191
The @app.post decorator to add a get route
192192
@@ -198,7 +198,7 @@ def inner(handler):
198198

199199
return inner
200200

201-
def put(self, endpoint):
201+
def put(self, endpoint: str) -> Callable[..., None]:
202202
"""
203203
The @app.put decorator to add a get route
204204
@@ -209,7 +209,7 @@ def inner(handler):
209209

210210
return inner
211211

212-
def delete(self, endpoint):
212+
def delete(self, endpoint: str) -> Callable[..., None]:
213213
"""
214214
The @app.delete decorator to add a get route
215215
@@ -221,7 +221,7 @@ def inner(handler):
221221

222222
return inner
223223

224-
def patch(self, endpoint):
224+
def patch(self, endpoint: str) -> Callable[..., None]:
225225
"""
226226
[The @app.patch decorator to add a get route]
227227
@@ -233,7 +233,7 @@ def inner(handler):
233233

234234
return inner
235235

236-
def head(self, endpoint):
236+
def head(self, endpoint: str) -> Callable[..., None]:
237237
"""
238238
The @app.head decorator to add a get route
239239
@@ -245,7 +245,7 @@ def inner(handler):
245245

246246
return inner
247247

248-
def options(self, endpoint):
248+
def options(self, endpoint: str) -> Callable[..., None]:
249249
"""
250250
The @app.options decorator to add a get route
251251
@@ -257,7 +257,7 @@ def inner(handler):
257257

258258
return inner
259259

260-
def connect(self, endpoint):
260+
def connect(self, endpoint: str) -> Callable[..., None]:
261261
"""
262262
The @app.connect decorator to add a get route
263263
@@ -269,7 +269,7 @@ def inner(handler):
269269

270270
return inner
271271

272-
def trace(self, endpoint):
272+
def trace(self, endpoint: str) -> Callable[..., None]:
273273
"""
274274
The @app.trace decorator to add a get route
275275

robyn/__init__.pyi

-130
This file was deleted.

robyn/argument_parser.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33

44
class ArgumentParser(argparse.ArgumentParser):
5-
def __init__(self):
5+
def __init__(self) -> None:
66
self.parser = argparse.ArgumentParser(
77
description="Robyn, a fast async web framework with a rust runtime."
88
)
@@ -38,19 +38,19 @@ def __init__(self):
3838
self.args = self.parser.parse_args()
3939

4040
@property
41-
def num_processes(self):
41+
def num_processes(self) -> int:
4242
return self.args.processes
4343

4444
@property
45-
def workers(self):
45+
def workers(self) -> int:
4646
return self.args.workers
4747

4848
@property
49-
def log_level(self):
49+
def log_level(self) -> str:
5050
return self.args.log_level
5151

5252
@property
53-
def is_dev(self):
53+
def is_dev(self) -> bool:
5454
_is_dev = self.args.dev
5555
if _is_dev and (self.num_processes != 1 or self.workers != 1):
5656
raise Exception("--processes and --workers shouldn't be used with --dev")

robyn/argument_parser.pyi

-23
This file was deleted.

robyn/dev_event_handler.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@
44

55

66
class EventHandler(FileSystemEventHandler):
7-
def __init__(self, file_name):
7+
def __init__(self, file_name) -> None:
88
self.file_name = file_name
99
self.processes = []
1010

11-
def start_server_first_time(self):
11+
def start_server_first_time(self) -> None:
1212
if self.processes:
1313
raise Exception("Something wrong with the server")
1414
self.processes.append(subprocess.Popen(["python3", self.file_name], start_new_session=False))
1515

16-
def on_any_event(self, event):
16+
def on_any_event(self, event) -> None:
1717
"""
1818
This function is a callback that will start a new server on every even change
1919

robyn/dev_event_handler.pyi

-11
This file was deleted.

0 commit comments

Comments
 (0)